From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Cc: Eric Brower <ebrower-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Daniel Smolik <marvin-0pWKB23IDFjrBKCeMvbIDA@public.gmane.org>
Subject: [PATCH] i2c-algo-pcf: Drop unused struct members
Date: Fri, 13 Jun 2008 10:25:10 +0200 [thread overview]
Message-ID: <20080613102510.0b40b352@hyperion.delvare> (raw)
Struct members udelay and timeout aren't used anywhere, so drop them.
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
---
Eric, Daniel, you're using i2c-algo-pcf more than me, can you please
check and confirm that this patch is correct? It applies on top of
Eric's patch for lost arbitration handling.
drivers/i2c/busses/i2c-elektor.c | 2 --
include/linux/i2c-algo-pcf.h | 4 ----
2 files changed, 6 deletions(-)
--- linux-2.6.26-rc5.orig/drivers/i2c/busses/i2c-elektor.c 2008-06-12 15:22:32.000000000 +0200
+++ linux-2.6.26-rc5/drivers/i2c/busses/i2c-elektor.c 2008-06-13 09:32:27.000000000 +0200
@@ -196,8 +196,6 @@ static struct i2c_algo_pcf_data pcf_isa_
.getown = pcf_isa_getown,
.getclock = pcf_isa_getclock,
.waitforpin = pcf_isa_waitforpin,
- .udelay = 10,
- .timeout = 100,
};
static struct i2c_adapter pcf_isa_ops = {
--- linux-2.6.26-rc5.orig/include/linux/i2c-algo-pcf.h 2008-06-13 09:08:00.000000000 +0200
+++ linux-2.6.26-rc5/include/linux/i2c-algo-pcf.h 2008-06-13 09:11:50.000000000 +0200
@@ -33,10 +33,6 @@ struct i2c_algo_pcf_data {
int (*getclock) (void *data);
void (*waitforpin) (void);
- /* local settings */
- int udelay;
- int timeout;
-
/* Multi-master lost arbitration back-off delay (msecs)
* This should be set by the bus adapter or knowledgable client
* if bus is multi-mastered, else zero
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next reply other threads:[~2008-06-13 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 8:25 Jean Delvare [this message]
[not found] ` <20080613102510.0b40b352-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-13 15:54 ` [PATCH] i2c-algo-pcf: Drop unused struct members Eric Brower
[not found] ` <ec7cefb0806130854y66f93fa8x9b671b539d9b2492-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-13 16:36 ` Daniel Smolik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080613102510.0b40b352@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ebrower-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=marvin-0pWKB23IDFjrBKCeMvbIDA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox