Re: [PATCH] Bugfixes for i2c-cpm.c

Jean Delvare
2008-06-23T13:59:09Z

Hi Wolfram,

On Mon, 23 Jun 2008 14:44:25 +0200, Wolfram Sang wrote:
> On Fri, Jun 20, 2008 at 10:41:55AM +0200, Wolfram Sang wrote:
>
> Any new on this one? I think at least the interrupt fix should make it
> into 2.6.26. The mistakenly activated interrupt caused a regression
> here, which made at24 fail on writes.

I was away for the week-end and am now processing the stacked e-mail
and other real-life tasks (takes time.)

I fail to see how there would be a regression here given that the
i2c-cpm driver is new and is not in kernel 2.6.26. It will only be
merged in 2.6.27-rc1. Not to mean that we don't want to fix the bugs
quickly, but it feels less urgent than if it was in 2.6.26.

As far as the review is concerned, ideally Jochen would do it as the
driver author and someone who presumably has hardware to test the
driver (I don't.) If Jochen acks the patch then I can add it to my i2c
tree quickly.

Thanks,
--
Jean Delvare