public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Manuel Lauss <mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] i2c-au1550: fix PM support.
Date: Sat, 28 Jun 2008 19:57:05 +0200	[thread overview]
Message-ID: <20080628195705.202fef80@hyperion.delvare> (raw)
In-Reply-To: <20080628161232.22f0ba50@scarran>

Hi Manuel,

On Sat, 28 Jun 2008 16:12:32 +0200, Manuel Lauss wrote:
> Hi Jean,
> 
> > Hi Manuel,
> > 
> > On Thu, 19 Jun 2008 10:27:49 +0200, Manuel Lauss wrote:
> > > From: Manuel Lauss <mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
> > > 
> > > Factor out reset/disable code to separate functions as they are
> > > also required for suspend/resume.
> > > 
> > > Tested on Au1200.
> > > 
> > > Signed-off-by: Manuel Lauss <mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
> > > ---
> > >  drivers/i2c/busses/i2c-au1550.c |  119 +++++++++++++++++++++------------------
> > >  1 files changed, 64 insertions(+), 55 deletions(-)
> > 
> > This patch doesn't apply cleanly on top of 2.6.26-rc8. I can try to fix
> > it manually, but given that I can't even build the i2c-au1550 driver,
> > that's a bit risky. Can you please update the patch so that it applies
> > on top of 2.6.26-rc8, test again and resubmit?
> 
> Sorry about that; here is the new and tested patch.
> I took the opportunity to sneak one additional change in (runtime PM).
> 
> Thanks!
> 	Manuel Lauss
> 
> --
> 
> From: Manuel Lauss <mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
> Subject: [PATCH] i2c-au1550: fix PM support.
> 
> Fix driver power management:
> - suspend the PSC while driver is idle.
> - move PSC init/deinit to separate functions, as PSC must be
>   initialized/shutdown on resume/suspend.
> 
> Signed-off-by: Manuel Lauss <mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-au1550.c |  130 ++++++++++++++++++++++----------------
>  1 files changed, 75 insertions(+), 55 deletions(-)
> 

Applied, thanks.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

      reply	other threads:[~2008-06-28 17:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19  8:27 [PATCH] i2c-au1550: fix PM support Manuel Lauss
     [not found] ` <20080619082749.GA20058-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
2008-06-28  9:27   ` Jean Delvare
     [not found]     ` <20080628112746.32349c47-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-28 14:12       ` Manuel Lauss
2008-06-28 17:57         ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080628195705.202fef80@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=mano-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox