From: Jean Delvare <khali@linux-fr.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
i2c@lm-sensors.org
Subject: Re: [PATCH 2/2] Add the of_find_i2c_device_by_node function, V4
Date: Tue, 1 Jul 2008 18:29:49 +0200 [thread overview]
Message-ID: <20080701182949.12119d6e@hyperion.delvare> (raw)
In-Reply-To: <9e4733910807010812h30e49144v5b3012e6c156ecca@mail.gmail.com>
On Tue, 1 Jul 2008 11:12:58 -0400, Jon Smirl wrote:
> On 7/1/08, Jean Delvare <khali@linux-fr.org> wrote:
> > I'm fine with this patch. In particular, exporting i2c_bus_type is OK.
> > It was un-exported only because it had no user left, but it can be
> > exported again if needed.
>
> Another solution would be to move drivers/of/of_i2c into the i2c
> directory and make it part of i2c core on powerpc builds.
I don't think this is a good idea. Merging arch-specific code (or
half-arch-specific code in this case) into arch-neutral drivers ends up
being a pain to maintain. People will keep sending me patches for stuff
I don't know anything about and can't help with. Having of-specific
stuff in just one directory as is the case now sounds much better to
me. All it's missing is a MAINTAINERS entry.
--
Jean Delvare
next prev parent reply other threads:[~2008-07-01 16:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 23:01 [PATCH 1/2] Convert i2c-mpc from a platform driver into a of_platform driver, V4 Jon Smirl
2008-06-30 23:01 ` [PATCH 2/2] Add the of_find_i2c_device_by_node function, V4 Jon Smirl
2008-07-01 15:05 ` Jean Delvare
2008-07-01 15:12 ` Jon Smirl
2008-07-01 16:29 ` Jean Delvare [this message]
[not found] ` <20080701182949.12119d6e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-07-01 16:38 ` Jon Smirl
[not found] ` <9e4733910807010938w67bab979tfba888641debe72f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-01 16:44 ` Jean Delvare
2008-07-01 16:45 ` Grant Likely
[not found] ` <20080701164518.GG6918-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
2008-07-01 17:01 ` Jean Delvare
[not found] ` <20080701190151.76782bbd-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-07-01 17:06 ` Jon Smirl
[not found] ` <9e4733910807011006t20c7689ctfe26931f96c84092-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-01 18:24 ` Jean Delvare
2008-07-01 16:43 ` Grant Likely
2008-07-01 17:00 ` Jon Smirl
2008-07-01 17:12 ` Jean Delvare
2008-07-01 17:27 ` Jon Smirl
2008-07-01 18:18 ` Jon Smirl
2008-07-01 18:51 ` Jean Delvare
2008-07-01 15:48 ` Jochen Friedrich
2008-07-01 16:29 ` Jon Smirl
2008-07-01 16:35 ` Jean Delvare
2008-07-01 16:14 ` [PATCH 1/2] Convert i2c-mpc from a platform driver into a of_platform driver, V4 Jean Delvare
2008-07-02 13:33 ` [i2c] " Wolfram Sang
2008-07-02 14:36 ` Jean Delvare
2008-07-09 17:22 ` Grant Likely
[not found] ` <fa686aa40807091022q22f6be99j89f311780bd3d369-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-10 16:36 ` Timur Tabi
2008-07-11 18:12 ` Grant Likely
2008-07-11 18:45 ` Anton Vorontsov
2008-07-11 18:54 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701182949.12119d6e@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=i2c@lm-sensors.org \
--cc=jonsmirl@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox