From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 1/1] I2C pxa fast mode (400khz) support
Date: Fri, 11 Jul 2008 19:20:29 -0700 [thread overview]
Message-ID: <200807111920.29739.david-b@pacbell.net> (raw)
In-Reply-To: <20080710132956.GG30539-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
On Thursday 10 July 2008, Ben Dooks wrote:
> On Thu, Jul 03, 2008 at 10:00:36AM +0800, Eric Miao wrote:
> > Jonathan Cameron wrote:
> > > Add fast_mode option to i2c_pxa_platform_data and use it to set the ICR_FM bit
> > > appropriately when i2c_pxa_reset is called. Parameter called fast_mode rather
> > > than frequency as this driver is also used for the i2c_pxa_pwr bus which has
> > > different normal and fast frequencies.
> >
> > Maybe we should convert that (as well as 'use_pio') to a bit field to save
> > another byte.
>
> I think use_pio and fast_mode could both be bits.
Or alternatively, "bool" ... which is usually a byte, and
on ARM will let GCC eliminate a comparision instruction.
Just load byte and branch on zero/nonzero, vs needing one
more instruction. (In odd cases, it can be more important
to conserve the extra seven bits.)
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-07-12 2:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 15:26 [PATCH 1/1] I2C pxa fast mode (400khz) support Jonathan Cameron
[not found] ` <486B9E30.80806-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-07-03 2:00 ` Eric Miao
2008-07-10 13:29 ` [i2c] " Ben Dooks
[not found] ` <20080710132956.GG30539-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-07-12 2:20 ` David Brownell [this message]
[not found] ` <200807111920.29739.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-07-12 21:02 ` Troy Kisky
[not found] ` <48791BF8.8080500-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2008-07-12 21:35 ` David Brownell
2008-07-09 16:48 ` Jean Delvare
2008-07-10 13:31 ` [i2c] " Ben Dooks
[not found] ` <20080710133150.GH30539-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-07-10 13:48 ` eric miao
2008-07-13 15:40 ` [i2c] " Jonathan Cameron
2008-07-15 9:43 ` Ben Dooks
2008-07-15 9:54 ` Russell King - ARM Linux
2008-07-15 10:37 ` Uwe Kleine-König
2008-07-15 10:51 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807111920.29739.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox