public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Troy Kisky
	<troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
Cc: linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org,
	Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 1/1] I2C pxa fast mode (400khz) support
Date: Sat, 12 Jul 2008 14:35:06 -0700	[thread overview]
Message-ID: <200807121435.06773.david-b@pacbell.net> (raw)
In-Reply-To: <48791BF8.8080500-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>

> >> I think use_pio and fast_mode could both be bits.
> > 
> > Or alternatively, "bool" ... which is usually a byte, and
> > on ARM will let GCC eliminate a comparision instruction.
> > Just load byte and branch on zero/nonzero, vs needing one
> > more instruction.
> 
> Unfortunately, on ARM the LDR/LDRB instructions can not
> update the condition codes.

Right, sorry -- I was looking at MOV not LDRB.

I don't use assembler often enough to remember
that little asymmetry:  data movement involving
memory uses different notations and instructions.

If only the instruction set were as regular as
a PDP-11 ... ;)


_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

  parent reply	other threads:[~2008-07-12 21:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-02 15:26 [PATCH 1/1] I2C pxa fast mode (400khz) support Jonathan Cameron
     [not found] ` <486B9E30.80806-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-07-03  2:00   ` Eric Miao
2008-07-10 13:29     ` [i2c] " Ben Dooks
     [not found]       ` <20080710132956.GG30539-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-07-12  2:20         ` David Brownell
     [not found]           ` <200807111920.29739.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-07-12 21:02             ` Troy Kisky
     [not found]               ` <48791BF8.8080500-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2008-07-12 21:35                 ` David Brownell [this message]
2008-07-09 16:48   ` Jean Delvare
2008-07-10 13:31 ` [i2c] " Ben Dooks
     [not found]   ` <20080710133150.GH30539-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-07-10 13:48     ` eric miao
2008-07-13 15:40       ` [i2c] " Jonathan Cameron
2008-07-15  9:43         ` Ben Dooks
2008-07-15  9:54           ` Russell King - ARM Linux
2008-07-15 10:37             ` Uwe Kleine-König
2008-07-15 10:51               ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807121435.06773.david-b@pacbell.net \
    --to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
    --cc=troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox