From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
Ben Dooks <ben-linux@fluff.org>,
i2c@lm-sensors.org
Subject: Re: [PATCH] i2c-pxa: fastmode support
Date: Fri, 1 Aug 2008 11:09:36 +0100 [thread overview]
Message-ID: <20080801100936.GB17442@flint.arm.linux.org.uk> (raw)
In-Reply-To: <4892E014.3040208@cam.ac.uk>
On Fri, Aug 01, 2008 at 11:06:12AM +0100, Jonathan Cameron wrote:
> Ben Dooks wrote:
> > On Thu, Jul 31, 2008 at 04:56:53PM +0100, Jonathan Cameron wrote:
> >> From: Jonathan Cameron <jic23@cam.ac.uk>
> >>
> >> Add fast_mode option to i2c_pxa_platform_data and use it to set the ICR_FM bit
> >> appropriately when i2c_pxa_reset is called. Parameter called fast_mode rather
> >> than frequency as this driver is also used for the i2c_pxa_pwr bus which has
> >> different normal and fast frequencies.
> >>
> >> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
> >> --
> >> This is basically a repost of the original patch with use_pio and fast_mode converted
> >> to bit fields as suggested / agreed by Eric Miao and Ben Dooks.
> >
> > please ensure your descriptions are wrapped to less than 77 characters
> > per line.
> Will do, sorry about that bit of carelessness.
Less than 72 is preferable - because tools (eg, git log) commonly prefix
the comments with one tab.
> Not something I care about that much either way and I'm guessing by
> the would be nice that you don't either. I'll repost the patch without.
Preferred without the space.
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2008-08-01 10:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 15:56 [PATCH] i2c-pxa: fastmode support Jonathan Cameron
[not found] ` <4891E0C5.7020009-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-01 1:29 ` Eric Miao
2008-08-01 9:49 ` Jonathan Cameron
2008-08-01 9:42 ` Ben Dooks
[not found] ` <20080801094257.GK26938-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2008-08-01 10:06 ` Jonathan Cameron
2008-08-01 10:09 ` Russell King - ARM Linux [this message]
2008-08-01 10:12 ` Jonathan Cameron
[not found] ` <4892E183.7090601-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-01 10:16 ` [PATCH] i2c-pxa: fastmode support (format cleanups) Jonathan Cameron
[not found] ` <4892E28E.40202-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-01 10:37 ` Eric Miao
2008-08-01 10:08 ` [PATCH] i2c-pxa: fastmode support (with suggested fixes) Jonathan Cameron
[not found] ` <4892E08F.4000907-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-08-06 22:40 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801100936.GB17442@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ben-linux@fluff.org \
--cc=i2c@lm-sensors.org \
--cc=jic23@cam.ac.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox