From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Ivo Manca <pinkel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Hans de Goede <j.w.r.degoede-fbo2DhPpy/Q@public.gmane.org>,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 02/03] i2c-i801: Fix alignment issues
Date: Tue, 12 Aug 2008 10:17:53 +0200 [thread overview]
Message-ID: <20080812101753.592294a3@hyperion.delvare> (raw)
In-Reply-To: <488762E5.2030109-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, 23 Jul 2008 18:57:09 +0200, Ivo Manca wrote:
> This patch fixes alignment issues introduced by previous patch.
>
> Signed-off-by: Ivo Manca <pinkel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> This patch depends on: [PATCH 01/03] i2c-i801: Add basic interrupt support
> --- i2c-i801-nolayout.c 2008-07-07 15:05:21.000000000 +0200
> +++ i2c-i801.c 2008-07-07 15:04:25.000000000 +0200
> @@ -210,24 +210,24 @@ static int i801_transaction(int xact)
> ((temp = i801_get_status(algo_data))
> & I801_HST_STS_MASK_NORM), HZ/2);
> } else {
> - outb_p(xact | I801_START, SMBHSTCNT);
> + outb_p(xact | I801_START, SMBHSTCNT);
>
> - /* We will always wait for a fraction of a second! */
> - do {
> - msleep(1);
> - temp = inb_p(SMBHSTSTS);
> - } while ((temp & SMBHSTSTS_HOST_BUSY) && (timeout++ < MAX_TIMEOUT));
> + /* We will always wait for a fraction of a second! */
> + do {
> + msleep(1);
> + temp = inb_p(SMBHSTSTS);
> + } while ((temp & SMBHSTSTS_HOST_BUSY) && (timeout++ < MAX_TIMEOUT));
>
> - /* If the SMBus is still busy, we give up */
> - if (timeout >= MAX_TIMEOUT) {
> - dev_dbg(&I801_dev->dev, "SMBus Timeout!\n");
> - result = -1;
> - /* try to stop the current command */
> - dev_dbg(&I801_dev->dev, "Terminating the current operation\n");
> - outb_p(inb_p(SMBHSTCNT) | SMBHSTCNT_KILL, SMBHSTCNT);
> - msleep(1);
> - outb_p(inb_p(SMBHSTCNT) & (~SMBHSTCNT_KILL), SMBHSTCNT);
> - }
> + /* If the SMBus is still busy, we give up */
> + if (timeout >= MAX_TIMEOUT) {
> + dev_dbg(&I801_dev->dev, "SMBus Timeout!\n");
> + result = -1;
> + /* try to stop the current command */
> + dev_dbg(&I801_dev->dev, "Terminating the current operation\n");
> + outb_p(inb_p(SMBHSTCNT) | SMBHSTCNT_KILL, SMBHSTCNT);
> + msleep(1);
> + outb_p(inb_p(SMBHSTCNT) & (~SMBHSTCNT_KILL), SMBHSTCNT);
> + }
> }
>
> if (temp & SMBHSTSTS_FAILED) {
OK. There's no real need to make this a separate patch. In fact I think
your first patch would be easier to read with these alignment issues
fixed, as it makes it easier to figure out what code paths your changes
are replacing. As a matter of fact, I applied this second patch before
reviewing the first one.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-08-12 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 16:57 [PATCH 02/03] i2c-i801: Fix alignment issues Ivo Manca
[not found] ` <488762E5.2030109-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-08-12 8:17 ` Jean Delvare [this message]
[not found] ` <20080812101753.592294a3-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-08-12 20:43 ` Ivo Manca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080812101753.592294a3@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=j.w.r.degoede-fbo2DhPpy/Q@public.gmane.org \
--cc=pinkel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox