Re: [PATCH V11] I2C driver for IMX

[Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>]

On Mon, Aug 11, 2008 at 10:00:57AM +0200, Jean Delvare wrote:
> Hi Darius,
> 
> On Mon, 11 Aug 2008 10:18:48 +0300, Darius wrote:
> > Ben Dooks wrote:
> > > On Fri, Aug 08, 2008 at 11:51:16AM +0200, Jean Delvare wrote:
> > >> On Wed, 23 Jul 2008 10:20:12 +0300, Darius wrote:
> > >>> Description:
> > >>>
> > >>> Implementation of I2C Adapter/Algorithm Driver
> > >>> for I2C Bus integrated in Freescale's i.MXL and i.MX1 processors
> > >>>
> > >>> Changes from V10 version:
> > >>>
> > >>> - adapter class changed to I2C_CLASS_ALL
> > >> Not a smart move if you ask me. All embedded platforms are moving away
> > >> from I2C probing and now use I2C device description at the platform
> > >> level. I expect I2C_CLASS_ALL to be discarded in 2.6.28. Almost all
> > >> hwmon and rtc drivers have been converted to the new I2C device driver
> > >> matching scheme at this point, and the few remaining ones will
> > >> definitely be converted for 2.6.28, hopefully with all the other legacy
> > >> I2C drivers in the kernel tree.
> > 
> > Why I should leave i2c class hwmon? i.MX I2C driver is common I2C driver,
> > suitable for almost every kind of I2C clients, not only hwmon.
> > For example digital camera and so on.
> 
> You shouldn't need any class at all, not even hwmon. Instead, you would
> use new-style I2C drivers for all your I2C devices.
> 
> Please remember that the i2c_adapter class describes the type of I2C
> devices which should be _probed_ for on the bus, not the type of I2C
> devices that can be present on the bus. If you know in advance which
> devices are present on the bus, you don't need to do any probing and
> thus leaving the class empty is OK.
> 
> > (...)
> > To merge this driver into kernel, we have to merge our and Pengutronix
> > patches for ARCH_MXC first, because it depends on these patches.
> > This I2C driver is not only for MX1 processors but for all i.MX family
> > from now. Therefore it needs platform data and header file from arch dir.
> > It does not compile before our ARCH_MXC patches are applied.
> 
> Your driver depends on ARCH_IMX at this point so it doesn't matter what
> the MXC architecture does. I guess you will want to update the
> dependency later when the MXC architecture is ready for your driver.

If it compiles as-is, we can commit it in the next merge window,
otherwise there's not a lot of point in merging code that cannot
compile.

-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c