From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Huang Weiyi <weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org
Subject: Re: i2c: remove unused #include <version.h>
Date: Mon, 25 Aug 2008 09:49:23 +0200 [thread overview]
Message-ID: <20080825094923.37dacad8@hyperion.delvare> (raw)
In-Reply-To: <20080823094544.2b79f563-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
On Sat, 23 Aug 2008 09:45:44 +0200, Jean Delvare wrote:
> On Sat, 23 Aug 2008 13:56:04 +0800, Huang Weiyi wrote:
> > The driver(s) below do not use LINUX_VERSION_CODE nor KERNEL_VERSION.
> > drivers/i2c/busses/i2c-at91.c
> >
> > This patch removes the said #include <version.h>.
> >
> > Signed-off-by: Huang Weiyi <weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> > index c1adcdb..9efb021 100644
> > --- a/drivers/i2c/busses/i2c-at91.c
> > +++ b/drivers/i2c/busses/i2c-at91.c
> > @@ -14,7 +14,6 @@
> > */
> >
> > #include <linux/module.h>
> > -#include <linux/version.h>
> > #include <linux/kernel.h>
> > #include <linux/err.h>
> > #include <linux/slab.h>
> >
>
> Applied, thanks.
Actually, Adrian Bunk sent this fix to Linus already, so I'm backing
out your version from my tree.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
prev parent reply other threads:[~2008-08-25 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 5:56 i2c: remove unused #include <version.h> Huang Weiyi
[not found] ` <20080823130840.1265.WEIYI.HUANG-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-08-23 7:45 ` Jean Delvare
[not found] ` <20080823094544.2b79f563-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-08-25 7:49 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080825094923.37dacad8@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=weiyi.huang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox