From: Jean Delvare <khali@linux-fr.org>
To: Seth Heasley <seth.heasley@intel.com>
Cc: i2c@lm-sensors.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org
Subject: Re: [PATCH 2.6.27-rc4][RESEND] irq: irq and pci_ids patch for Intel Ibex Peak DeviceIDs
Date: Fri, 29 Aug 2008 10:01:53 +0200 [thread overview]
Message-ID: <20080829100153.5ccdf0ae@hyperion.delvare> (raw)
In-Reply-To: <200808281540.59657.seth.heasley@intel.com>
On Thu, 28 Aug 2008 15:40:59 -0700, Seth Heasley wrote:
> This patch updates the Intel Ibex Peak (PCH) LPC and SMBus Controller DeviceIDs.
>
> The LPC Controller ID is set by Firmware within the range of 0x3b00-3b1f. This range is included in pci_ids.h using min and max values, and irq.c now has code to handle the range (in lieu of 32 additions to a SWITCH statement).
>
> The SMBus Controller ID is a fixed-value and will not change.
>
> Signed-off-by: Seth Heasley <seth.heasley@intel.com>
>
> --- linux-2.6/include/linux/pci_ids.h.orig 2008-08-27 11:54:07.000000000 -0700
> +++ linux-2.6/include/linux/pci_ids.h 2008-08-28 14:59:35.000000000 -0700
> @@ -2428,9 +2428,9 @@
> #define PCI_DEVICE_ID_INTEL_ICH10_3 0x3a1a
> #define PCI_DEVICE_ID_INTEL_ICH10_4 0x3a30
> #define PCI_DEVICE_ID_INTEL_ICH10_5 0x3a60
> -#define PCI_DEVICE_ID_INTEL_PCH_0 0x3b10
> -#define PCI_DEVICE_ID_INTEL_PCH_1 0x3b11
> -#define PCI_DEVICE_ID_INTEL_PCH_2 0x3b30
> +#define PCI_DEVICE_ID_INTEL_PCH_LPC_MIN 0x3b00
> +#define PCI_DEVICE_ID_INTEL_PCH_LPC_MAX 0x3b1f
> +#define PCI_DEVICE_ID_INTEL_PCH_SMBUS 0x3b30
> #define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
> #define PCI_DEVICE_ID_INTEL_5100_16 0x65f0
> #define PCI_DEVICE_ID_INTEL_5100_21 0x65f5
> --- linux-2.6/arch/x86/pci/irq.c.orig 2008-08-27 11:53:13.000000000 -0700
> +++ linux-2.6/arch/x86/pci/irq.c 2008-08-28 15:12:04.000000000 -0700
> @@ -590,13 +590,20 @@
> case PCI_DEVICE_ID_INTEL_ICH10_1:
> case PCI_DEVICE_ID_INTEL_ICH10_2:
> case PCI_DEVICE_ID_INTEL_ICH10_3:
> - case PCI_DEVICE_ID_INTEL_PCH_0:
> - case PCI_DEVICE_ID_INTEL_PCH_1:
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
> return 1;
> }
> +
> + if ((device >= PCI_DEVICE_ID_INTEL_PCH_LPC_MIN) &&
> + (device <= PCI_DEVICE_ID_INTEL_PCH_LPC_MAX)) {
> + r->name = "PIIX/ICH";
> + r->get = pirq_piix_get;
> + r->set = pirq_piix_set;
> + return 1;
> + }
> +
> return 0;
> }
>
Looks good to me, thanks for doing that.
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
next prev parent reply other threads:[~2008-08-29 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 22:40 [PATCH 2.6.27-rc4][RESEND] irq: irq and pci_ids patch for Intel Ibex Peak DeviceIDs Seth Heasley
2008-08-29 8:01 ` Jean Delvare [this message]
2008-09-09 18:44 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829100153.5ccdf0ae@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=i2c@lm-sensors.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox