Re: PCA9665 support added to i2c-algo-pca and i2c-pca-isa.c

From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Marco Aurelio da Costa <costa-nrw9SyMmU14AvxtiuMwx3w@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: PCA9665 support added to i2c-algo-pca and i2c-pca-isa.c
Date: Fri, 19 Sep 2008 16:55:00 +0200	[thread overview]
Message-ID: <20080919145500.GH4307@pengutronix.de> (raw)
In-Reply-To: <48D3B5B7.1060402-nrw9SyMmU14AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 1002 bytes --]

> Here is the patch against 2.6.26.5.
> Please tell me if I did something very wrong ;)

I'm just about to leave the office, so just the first notes. Will have a
deeper look later this evening...

> +static void pca9665_reset(void *pd)
> +{
> +	struct i2c_algo_pca_data *adap = pd;
> +	pca_outw(adap,I2C_PCA_INDPTR,I2C_PCA_IPRESET);
> +	pca_outw(adap,I2C_PCA_IND,0xA5);
> +	pca_outw(adap,I2C_PCA_IND,0x5A);

CodingStyle issues (space after comma)...

> +	if (pca_data->i2c_chip_type != I2C_PCA_CHIP_9564 && pca_data->i2c_chip_type != I2C_PCA_CHIP_9665 ) {

Line is longer than 80 chars. Please be sure to have run checkpatch.pl
before submitting.

> +	

Trailing whitespaces here (and in some other places).

> +		int minTLow, minTHi;

This style of naming is at least unusual in kernel. Maybe min_tlow?

So much for now, more later...

   Wolfram

-- 
  Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c