From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/2] i2c: expand I2C's id.name to 23 characters Date: Fri, 19 Sep 2008 14:39:03 -0600 Message-ID: <20080919203903.GA10187@secretlab.ca> References: <20080919180339.GA13899@oksana.dev.rtsoft.ru> <20080919220308.3173320e@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20080919220308.3173320e@hyperion.delvare> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Jean Delvare Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org, Ben Dooks List-Id: linux-i2c@vger.kernel.org On Fri, Sep 19, 2008 at 10:03:08PM +0200, Jean Delvare wrote: > On Fri, 19 Sep 2008 22:03:39 +0400, Anton Vorontsov wrote: > > It was discussed[1] that we should match on the first (most specific) > > entry in the device tree. > > > > The most lengthy I2C compatible entry for the MPC8349E-mITX MCU > > devices is "mc9s08qg8-mpc8349emitx" (w/o vendor name). This means > > that we have to allow longer IDs to be used in the I2C subsystem. > > > > [1] http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg21196.html > > Nack. Just come up with shorter names. "mc9s08qg8-mpc8349emitx" is > simply too long to start with. Looking at the mcu_mpc8349emitx driver > you just submitted, you are clearly abusing the i2c client name to pass > platform-specific information, and that's bad. I'm not even sure why > you do that, given that all the names are then handled the same as far > as I can see. The whole "matching on the first entry" thing is just a Linux-internal heuristic. If the heuristic breaks down (like it does here), then there is a mechanism to override it in of_base.c which has a compatible-->modalias translation table. g.