public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 2.6.27-rc7] i2c: do earlier driver model init
@ 2008-09-24 16:15 David Brownell
       [not found] ` <200809240915.39917.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2008-09-24 16:15 UTC (permalink / raw)
  To: i2c-GZX6beZjE8VD60Wz+7aTrA

From: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>

Move I2C driver model init earlier in the boot sequence.

This avoids oopsing in statically linked systems when some
subsystems register I2C drivers in subsys_initcall() code,
but those subsystems are linked (and initialized) before I2C.

Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
---
 drivers/i2c/i2c-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1143,7 +1143,7 @@ static void __exit i2c_exit(void)
 	bus_unregister(&i2c_bus_type);
 }
 
-subsys_initcall(i2c_init);
+postcore_initcall(i2c_init);
 module_exit(i2c_exit);
 
 /* ----------------------------------------------------

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2.6.27-rc7] i2c: do earlier driver model init
       [not found] ` <200809240915.39917.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
@ 2008-09-30 11:13   ` Jean Delvare
  0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2008-09-30 11:13 UTC (permalink / raw)
  To: David Brownell; +Cc: i2c-GZX6beZjE8VD60Wz+7aTrA

Hi David,

On Wed, 24 Sep 2008 09:15:39 -0700, David Brownell wrote:
> From: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> 
> Move I2C driver model init earlier in the boot sequence.
> 
> This avoids oopsing in statically linked systems when some
> subsystems register I2C drivers in subsys_initcall() code,
> but those subsystems are linked (and initialized) before I2C.
> 
> Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> ---
>  drivers/i2c/i2c-core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1143,7 +1143,7 @@ static void __exit i2c_exit(void)
>  	bus_unregister(&i2c_bus_type);
>  }
>  
> -subsys_initcall(i2c_init);
> +postcore_initcall(i2c_init);
>  module_exit(i2c_exit);
>  

Patch applied, thanks. Will go in 2.6.28, NOT 2.6.27 (too late there
for such a change.)

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-30 11:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-24 16:15 [patch 2.6.27-rc7] i2c: do earlier driver model init David Brownell
     [not found] ` <200809240915.39917.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-09-30 11:13   ` Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox