From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility Date: Thu, 16 Oct 2008 11:06:01 -0700 Message-ID: <200810161106.02871.david-b@pacbell.net> References: <20081014184038.6f1b5c59@i1501.lan.towertech.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081014184038.6f1b5c59-1Z+4F8PJzVxlecnr3/Sf3RLwuzhV/fVh@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Alessandro Zummo , BARRE Sebastien Cc: frederic Rodo , Rodolfo Giometti , "i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Tuesday 14 October 2008, Alessandro Zummo wrote: > On Tue, 14 Oct 2008 17:57:29 +0200 > BARRE Sebastien wrote: > > > > seems almost ok. please send your latest version to me and cc to > > > the rtc-list for the final review. if it passed Jean's tests > > > I'm confident it's quite ready for inclusion :) > > > > Patch is attached to preserve tabs. > > bzzzt. wrong! patches must be submitted inline Though that's not a hard-and-fast policy; when the submitter can't get relevant mailers to avoid mangling the patches, it's better to attach them than otherwise. However, see Documentation/email-clients.txt More generally, this patch isn't much good since it doesn't even *apply* ... on top of a pending patch to the same driver, which has been in the MM tree since late July or so. My suggestion: since that patch was recently (last night) sent to Linus for merging, wait until it's in mainline GIT. Then refresh and re-send the patch. - Dave _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c