From: David Brownell <david-b@pacbell.net>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com, sbarre@sdelcc.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"i2c@lm-sensors.org" <i2c@lm-sensors.org>,
Jean Delvare <khali@linux-fr.org>,
Rodolfo Giometti <giometti@enneenne.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [rtc-linux] [i2c] [PATCH] rtc-ds1307 : SMBus compatibility
Date: Mon, 27 Oct 2008 14:29:24 -0700 [thread overview]
Message-ID: <200810271429.25490.david-b@pacbell.net> (raw)
In-Reply-To: <20081021202938.2eca3ac1@i1501.lan.towertech.it>
On Tuesday 21 October 2008, Alessandro Zummo wrote:
> > I've tested it with ds1307 chip.
> > Is somebody can test it on ds1337/ds1338 ?
>
> Given the amount of changes I need some Tested-bys
> for the patch to go thru.
I tested these changes on my trusty ds1307 system using i2c-gpio
(vs a "real SMBus controller") and it works just fine.
Of the nine changed I/O calls, testing with the ds1307 covers
all but the three supporting the new alarm calls. Given that
those alarm changes are "obvious", I actually don't have any
qualms signing off on these changes ... though it would of
course be good to have Rodolfo re-test his alarm code. (It's
freshly merged in any case, so it merits testing just in case
a problem snuck in!)
- Dave
prev parent reply other threads:[~2008-10-27 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C1C62166118DFA4A8BBA01A2411F0D170E9BE59C2F@PRI-MBX-101.dom1.vinci-energies.net>
[not found] ` <20081016121843.2e0c3792.akpm@linux-foundation.org>
[not found] ` <20081016121843.2e0c3792.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-10-17 15:11 ` [PATCH] rtc-ds1307 : SMBus compatibility BARRE Sebastien
2008-10-21 18:29 ` [rtc-linux] [i2c] " Alessandro Zummo
2008-10-27 21:29 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810271429.25490.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=alessandro.zummo@towertech.it \
--cc=giometti@enneenne.com \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sbarre@sdelcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox