Re: [patch 2.6.28-rc5] i2c: remove i2c_adapter.clist_lock

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi David,

On Thu, 20 Nov 2008 14:38:08 -0800, David Brownell wrote:
> From: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> 
> Move list add/remove operations now protected by i2c_adapter.clist_lock
> into the driver model probe() and remove() calls, where driver model
> locking protects them.  This is a minor code and data shrink.
> 
> Note that the adapter "child list" is still protected inconsistently;
> this patch just simplifies locking, and makes this list more directly
> mirror the one maintained by the driver model.  Removing this list may
> need to wait until the legacy I2C driver binding model is removed.
> 
> Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> ---
>  drivers/i2c/i2c-core.c |   17 ++++-------------
>  include/linux/i2c.h    |    1 -
>  2 files changed, 4 insertions(+), 14 deletions(-)

I'm not sure I want to take this change at this point. Call me chicken,
but I seem to recall problems with legacy i2c clients last time we
tried to clean up this area. So I'd rather work on killing the legacy
binding model now, and once this is done, we can look into i2c-core
cleanups again.

The list of i2c drivers that still need to be converted can be found
here:
http://jdelvare.pck.nerim.net/linux/legacy_i2c_driver.list

Drivers that are neither marked "*" (done) nor "-" (deleted) are left
to convert.

Thanks,
-- 
Jean Delvare