Re: [patch 2.6.28-rc5] i2c: remove i2c_adapter.clist_lock

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Tue, 25 Nov 2008 02:24:01 -0800, David Brownell wrote:
> On Tuesday 25 November 2008, Jean Delvare wrote:
> > I'm not sure I want to take this change at this point. Call me chicken,
> > but I seem to recall problems with legacy i2c clients last time we
> > tried to clean up this area.
> 
> I did test this with the legacy "eeprom" and "i2c-stub" as you had
> suggested.  Worked fine ... this is different from previous passes,
> as it removes the lock instead of the list, and doesn't attempt to
> change how the list is (mis/ab)used.

Which kernel version? Since 2.6.27, the eeprom driver is no longer a
legacy driver. Instead it's a new-style driver with the
optional .detect() callback.

This is why I am reluctant to change this now: there aren't too many
legacy drivers left, so testing their code paths isn't easy, and if
anything isn't correct we might not notice it until it hits the users.

> But if you prefer to wait until the list can go too, OK.

Yes, please.

-- 
Jean Delvare