Re: [patch 1/2] i2c: misannotation in i2c-pmcmsp.c

Re: [patch 1/2] i2c: misannotation in i2c-pmcmsp.c

[Jean Delvare]

On Mon, 01 Dec 2008 14:17:38 -0800, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org wrote:
> From: Harvey Harrison <harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> tmp is used as host-endian and is loaded from a be64, fix the cast and the
> endian accessor used.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> ---
> 
>  drivers/i2c/busses/i2c-pmcmsp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/i2c/busses/i2c-pmcmsp.c~i2c-misannotation-in-i2c-pmcmspc drivers/i2c/busses/i2c-pmcmsp.c
> --- a/drivers/i2c/busses/i2c-pmcmsp.c~i2c-misannotation-in-i2c-pmcmspc
> +++ a/drivers/i2c/busses/i2c-pmcmsp.c
> @@ -486,7 +486,7 @@ static enum pmcmsptwi_xfer_result pmcmsp
>  
>  	if (cmd->type == MSP_TWI_CMD_WRITE ||
>  	    cmd->type == MSP_TWI_CMD_WRITE_READ) {
> -		__be64 tmp = cpu_to_be64p((u64 *)cmd->write_data);
> +		u64 tmp = be64_to_cpup((__be64 *)cmd->write_data);
>  		tmp >>= (MSP_MAX_BYTES_PER_RW - cmd->write_len) * 8;
>  		dev_dbg(&pmcmsptwi_adapter.dev, "Writing 0x%016llx\n", tmp);
>  		pmcmsptwi_writel(tmp & 0x00000000ffffffffLL,

Ben, Marc, any comment on this?

-- 
Jean Delvare