From: Jean Delvare <khali@linux-fr.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-i2c@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 12/33] i2c: Make static
Date: Tue, 9 Dec 2008 20:04:09 +0100 [thread overview]
Message-ID: <20081209200409.17fac29f@hyperion.delvare> (raw)
In-Reply-To: <493EBBD0.6070201@gmail.com>
On Tue, 09 Dec 2008 19:41:20 +0100, Roel Kluin wrote:
> Sparse asked whether these could be static.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/i2c/i2c-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index c6a63f4..1049615 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1699,7 +1699,8 @@ EXPORT_SYMBOL(i2c_smbus_write_word_data);
> * This executes the SMBus "process call" protocol, returning negative errno
> * else a 16-bit unsigned "word" received from the device.
> */
> -s32 i2c_smbus_process_call(struct i2c_client *client, u8 command, u16 value)
> +static s32 i2c_smbus_process_call(struct i2c_client *client, u8 command,
> + u16 value)
> {
> union i2c_smbus_data data;
> int status;
Nack:
drivers/i2c/i2c-core.c:EXPORT_SYMBOL(i2c_smbus_process_call);
--
Jean Delvare
next prev parent reply other threads:[~2008-12-09 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <493EA286.7080500@gmail.com>
[not found] ` <493EA286.7080500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-12-09 18:41 ` [PATCH 12/33] i2c: Make static Roel Kluin
2008-12-09 19:04 ` Jean Delvare [this message]
[not found] ` <20081209200409.17fac29f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-12-09 22:53 ` roel kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209200409.17fac29f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox