Re: [PATCH 4/4 v2] soc-camera: add support for MT9T031 CMOS camera sensor from Micron

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Guennadi,

Le Jeudi 18 Décembre 2008 09:40, Guennadi Liakhovetski a écrit :
> From: Guennadi Liakhovetski <lg-ynQEQJNshbs@public.gmane.org>
> 
> This camera is rather similar to MT9M001, but also has a couple of
> enhanced features, like pixel binning.

I didn't look at the datasheets, but just to make sure you didn't
overlook this possibility: wouldn't it make sense to have a single
driver for both devices? The i2c subsystem architecture makes this
easy.

> 
> Signed-off-by: Guennadi Liakhovetski <lg-ynQEQJNshbs@public.gmane.org>
> ---
> 
> Changes since v1: added
> 
>  i2c_set_clientdata(client, NULL);
> 
> in error path and in remove.
> 
>  drivers/media/video/Kconfig     |    6 +
>  drivers/media/video/Makefile    |    1 +
>  drivers/media/video/mt9t031.c   |  733 +++++++++++++++++++++++++++++++++++++++
>  include/media/v4l2-chip-ident.h |    1 +
>  4 files changed, 741 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/media/video/mt9t031.c
> (...)

I took a quick look at the code and it looks fine to me, for the
parts I can comment on. So this is:

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

-- 
Jean Delvare