Re: SMBus quick command problem

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Fri, 9 Jan 2009 16:03:11 +0100, Fabien Marteau wrote:
> Thanks Jean,
> 
> In fact I'm using the i2c-ocore (opencore) controller, and the «SMBus
> Quick Command» block the bus with the Linux standard driver
> (drivers/i2c/busses/i2c-ocores.c):
> http://www.opencores.org/forums.cgi/cores/2008/10/003391
> 
> Then to solve this problem I'm re-writing the driver to support each
> SMBus commands separately, following the linux documentation.
> If writing '1' on quick command block the bus, I will skip this test.

I don't get where you're going with rewriting the driver. You'll end up
with a larger driver doing exactly the same, without taking benefit of
the SMBus emulation layer from i2c-core. If the hardware has a problem
with Quick commands, rewriting the driver won't solve that. Better
intercept that case in the current driver and return an error.

Not that it really matters though, as I have yet to see any real-world
use case for the Quick command with data bit = 1. So what problem are
you trying to solve exactly?

-- 
Jean Delvare