* [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/
@ 2009-01-11 16:51 Anton Vorontsov
[not found] ` <20090111165136.GA26096-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Anton Vorontsov @ 2009-01-11 16:51 UTC (permalink / raw)
To: Kumar Gala
Cc: Jean Delvare, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A
This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/
directory. The new location suggested by Kumar Gala: as the driver is
83xx specific it's placed into arch/powerpc/platforms/83xx/.
Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
---
This is git patch.
arch/powerpc/platforms/83xx/Makefile | 1 +
.../powerpc/platforms/83xx}/mcu_mpc8349emitx.c | 0
arch/powerpc/platforms/Kconfig | 11 +++++++++++
drivers/i2c/chips/Kconfig | 11 -----------
drivers/i2c/chips/Makefile | 1 -
5 files changed, 12 insertions(+), 12 deletions(-)
rename {drivers/i2c/chips => arch/powerpc/platforms/83xx}/mcu_mpc8349emitx.c (100%)
diff --git a/arch/powerpc/platforms/83xx/Makefile b/arch/powerpc/platforms/83xx/Makefile
index ba5028e..051777c 100644
--- a/arch/powerpc/platforms/83xx/Makefile
+++ b/arch/powerpc/platforms/83xx/Makefile
@@ -3,6 +3,7 @@
#
obj-y := misc.o usb.o
obj-$(CONFIG_SUSPEND) += suspend.o suspend-asm.o
+obj-$(CONFIG_MCU_MPC8349EMITX) += mcu_mpc8349emitx.o
obj-$(CONFIG_MPC831x_RDB) += mpc831x_rdb.o
obj-$(CONFIG_MPC832x_RDB) += mpc832x_rdb.o
obj-$(CONFIG_MPC834x_MDS) += mpc834x_mds.o
diff --git a/drivers/i2c/chips/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
similarity index 100%
rename from drivers/i2c/chips/mcu_mpc8349emitx.c
rename to arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 47fe2be..200b9cb 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -323,4 +323,15 @@ config SIMPLE_GPIO
chip-selects, Ethernet/USB PHY's power and various other small
on-board peripherals.
+config MCU_MPC8349EMITX
+ tristate "MPC8349E-mITX MCU driver"
+ depends on I2C && PPC_83xx
+ select GENERIC_GPIO
+ select ARCH_REQUIRE_GPIOLIB
+ help
+ Say Y here to enable soft power-off functionality on the Freescale
+ boards with the MPC8349E-mITX-compatible MCU chips. This driver will
+ also register MCU GPIOs with the generic GPIO API, so you'll able
+ to use MCU pins as GPIOs.
+
endmenu
diff --git a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig
index 4c35702..d383e81 100644
--- a/drivers/i2c/chips/Kconfig
+++ b/drivers/i2c/chips/Kconfig
@@ -174,15 +174,4 @@ config MENELAUS
and other features that are often used in portable devices like
cell phones and PDAs.
-config MCU_MPC8349EMITX
- tristate "MPC8349E-mITX MCU driver"
- depends on I2C && PPC_83xx
- select GENERIC_GPIO
- select ARCH_REQUIRE_GPIOLIB
- help
- Say Y here to enable soft power-off functionality on the Freescale
- boards with the MPC8349E-mITX-compatible MCU chips. This driver will
- also register MCU GPIOs with the generic GPIO API, so you'll able
- to use MCU pins as GPIOs.
-
endmenu
diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
index 23d2a31..7e769b0 100644
--- a/drivers/i2c/chips/Makefile
+++ b/drivers/i2c/chips/Makefile
@@ -22,7 +22,6 @@ obj-$(CONFIG_ISP1301_OMAP) += isp1301_omap.o
obj-$(CONFIG_TPS65010) += tps65010.o
obj-$(CONFIG_MENELAUS) += menelaus.o
obj-$(CONFIG_SENSORS_TSL2550) += tsl2550.o
-obj-$(CONFIG_MCU_MPC8349EMITX) += mcu_mpc8349emitx.o
ifeq ($(CONFIG_I2C_DEBUG_CHIP),y)
EXTRA_CFLAGS += -DDEBUG
--
1.5.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread[parent not found: <20090111165136.GA26096-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>]
* [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ [not found] ` <20090111165136.GA26096-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org> @ 2009-01-11 16:55 ` Anton Vorontsov [not found] ` <20090111165539.GA27223-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org> 2009-01-11 17:10 ` Jean Delvare 1 sibling, 1 reply; 9+ messages in thread From: Anton Vorontsov @ 2009-01-11 16:55 UTC (permalink / raw) To: Kumar Gala Cc: Jean Delvare, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, linux-i2c-u79uwXL29TY76Z2rM5mHXA This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/. Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> --- The same patch but suitable for patch(1). arch/powerpc/platforms/83xx/Makefile | 1 + arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 209 ++++++++++++++++++++++++ arch/powerpc/platforms/Kconfig | 11 ++ drivers/i2c/chips/Kconfig | 11 -- drivers/i2c/chips/Makefile | 1 - drivers/i2c/chips/mcu_mpc8349emitx.c | 209 ------------------------ 6 files changed, 221 insertions(+), 221 deletions(-) create mode 100644 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c delete mode 100644 drivers/i2c/chips/mcu_mpc8349emitx.c diff --git a/arch/powerpc/platforms/83xx/Makefile b/arch/powerpc/platforms/83xx/Makefile index ba5028e..051777c 100644 --- a/arch/powerpc/platforms/83xx/Makefile +++ b/arch/powerpc/platforms/83xx/Makefile @@ -3,6 +3,7 @@ # obj-y := misc.o usb.o obj-$(CONFIG_SUSPEND) += suspend.o suspend-asm.o +obj-$(CONFIG_MCU_MPC8349EMITX) += mcu_mpc8349emitx.o obj-$(CONFIG_MPC831x_RDB) += mpc831x_rdb.o obj-$(CONFIG_MPC832x_RDB) += mpc832x_rdb.o obj-$(CONFIG_MPC834x_MDS) += mpc834x_mds.o diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c new file mode 100644 index 0000000..82a9bcb --- /dev/null +++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c @@ -0,0 +1,209 @@ +/* + * Power Management and GPIO expander driver for MPC8349E-mITX-compatible MCU + * + * Copyright (c) 2008 MontaVista Software, Inc. + * + * Author: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + */ + +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/device.h> +#include <linux/mutex.h> +#include <linux/i2c.h> +#include <linux/gpio.h> +#include <linux/of.h> +#include <linux/of_gpio.h> +#include <asm/prom.h> +#include <asm/machdep.h> + +/* + * I don't have specifications for the MCU firmware, I found this register + * and bits positions by the trial&error method. + */ +#define MCU_REG_CTRL 0x20 +#define MCU_CTRL_POFF 0x40 + +#define MCU_NUM_GPIO 2 + +struct mcu { + struct mutex lock; + struct device_node *np; + struct i2c_client *client; + struct of_gpio_chip of_gc; + u8 reg_ctrl; +}; + +static struct mcu *glob_mcu; + +static void mcu_power_off(void) +{ + struct mcu *mcu = glob_mcu; + + pr_info("Sending power-off request to the MCU...\n"); + mutex_lock(&mcu->lock); + i2c_smbus_write_byte_data(glob_mcu->client, MCU_REG_CTRL, + mcu->reg_ctrl | MCU_CTRL_POFF); + mutex_unlock(&mcu->lock); +} + +static void mcu_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +{ + struct of_gpio_chip *of_gc = to_of_gpio_chip(gc); + struct mcu *mcu = container_of(of_gc, struct mcu, of_gc); + u8 bit = 1 << (4 + gpio); + + mutex_lock(&mcu->lock); + if (val) + mcu->reg_ctrl &= ~bit; + else + mcu->reg_ctrl |= bit; + + i2c_smbus_write_byte_data(mcu->client, MCU_REG_CTRL, mcu->reg_ctrl); + mutex_unlock(&mcu->lock); +} + +static int mcu_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) +{ + mcu_gpio_set(gc, gpio, val); + return 0; +} + +static int mcu_gpiochip_add(struct mcu *mcu) +{ + struct device_node *np; + struct of_gpio_chip *of_gc = &mcu->of_gc; + struct gpio_chip *gc = &of_gc->gc; + int ret; + + np = of_find_compatible_node(NULL, NULL, "fsl,mcu-mpc8349emitx"); + if (!np) + return -ENODEV; + + gc->owner = THIS_MODULE; + gc->label = np->full_name; + gc->can_sleep = 1; + gc->ngpio = MCU_NUM_GPIO; + gc->base = -1; + gc->set = mcu_gpio_set; + gc->direction_output = mcu_gpio_dir_out; + of_gc->gpio_cells = 2; + of_gc->xlate = of_gpio_simple_xlate; + + np->data = of_gc; + mcu->np = np; + + /* + * We don't want to lose the node, its ->data and ->full_name... + * So, if succeeded, we don't put the node here. + */ + ret = gpiochip_add(gc); + if (ret) + of_node_put(np); + return ret; +} + +static int mcu_gpiochip_remove(struct mcu *mcu) +{ + int ret; + + ret = gpiochip_remove(&mcu->of_gc.gc); + if (ret) + return ret; + of_node_put(mcu->np); + + return 0; +} + +static int __devinit mcu_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct mcu *mcu; + int ret; + + mcu = kzalloc(sizeof(*mcu), GFP_KERNEL); + if (!mcu) + return -ENOMEM; + + mutex_init(&mcu->lock); + mcu->client = client; + i2c_set_clientdata(client, mcu); + + ret = i2c_smbus_read_byte_data(mcu->client, MCU_REG_CTRL); + if (ret < 0) + goto err; + mcu->reg_ctrl = ret; + + ret = mcu_gpiochip_add(mcu); + if (ret) + goto err; + + /* XXX: this is potentially racy, but there is no lock for ppc_md */ + if (!ppc_md.power_off) { + glob_mcu = mcu; + ppc_md.power_off = mcu_power_off; + dev_info(&client->dev, "will provide power-off service\n"); + } + + return 0; +err: + kfree(mcu); + return ret; +} + +static int __devexit mcu_remove(struct i2c_client *client) +{ + struct mcu *mcu = i2c_get_clientdata(client); + int ret; + + if (glob_mcu == mcu) { + ppc_md.power_off = NULL; + glob_mcu = NULL; + } + + ret = mcu_gpiochip_remove(mcu); + if (ret) + return ret; + i2c_set_clientdata(client, NULL); + kfree(mcu); + return 0; +} + +static const struct i2c_device_id mcu_ids[] = { + { "mcu-mpc8349emitx", }, + {}, +}; +MODULE_DEVICE_TABLE(i2c, mcu_ids); + +static struct i2c_driver mcu_driver = { + .driver = { + .name = "mcu-mpc8349emitx", + .owner = THIS_MODULE, + }, + .probe = mcu_probe, + .remove = __devexit_p(mcu_remove), + .id_table = mcu_ids, +}; + +static int __init mcu_init(void) +{ + return i2c_add_driver(&mcu_driver); +} +module_init(mcu_init); + +static void __exit mcu_exit(void) +{ + i2c_del_driver(&mcu_driver); +} +module_exit(mcu_exit); + +MODULE_DESCRIPTION("Power Management and GPIO expander driver for " + "MPC8349E-mITX-compatible MCU"); +MODULE_AUTHOR("Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>"); +MODULE_LICENSE("GPL"); diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig index 47fe2be..200b9cb 100644 --- a/arch/powerpc/platforms/Kconfig +++ b/arch/powerpc/platforms/Kconfig @@ -323,4 +323,15 @@ config SIMPLE_GPIO chip-selects, Ethernet/USB PHY's power and various other small on-board peripherals. +config MCU_MPC8349EMITX + tristate "MPC8349E-mITX MCU driver" + depends on I2C && PPC_83xx + select GENERIC_GPIO + select ARCH_REQUIRE_GPIOLIB + help + Say Y here to enable soft power-off functionality on the Freescale + boards with the MPC8349E-mITX-compatible MCU chips. This driver will + also register MCU GPIOs with the generic GPIO API, so you'll able + to use MCU pins as GPIOs. + endmenu diff --git a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig index 4c35702..d383e81 100644 --- a/drivers/i2c/chips/Kconfig +++ b/drivers/i2c/chips/Kconfig @@ -174,15 +174,4 @@ config MENELAUS and other features that are often used in portable devices like cell phones and PDAs. -config MCU_MPC8349EMITX - tristate "MPC8349E-mITX MCU driver" - depends on I2C && PPC_83xx - select GENERIC_GPIO - select ARCH_REQUIRE_GPIOLIB - help - Say Y here to enable soft power-off functionality on the Freescale - boards with the MPC8349E-mITX-compatible MCU chips. This driver will - also register MCU GPIOs with the generic GPIO API, so you'll able - to use MCU pins as GPIOs. - endmenu diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile index 23d2a31..7e769b0 100644 --- a/drivers/i2c/chips/Makefile +++ b/drivers/i2c/chips/Makefile @@ -22,7 +22,6 @@ obj-$(CONFIG_ISP1301_OMAP) += isp1301_omap.o obj-$(CONFIG_TPS65010) += tps65010.o obj-$(CONFIG_MENELAUS) += menelaus.o obj-$(CONFIG_SENSORS_TSL2550) += tsl2550.o -obj-$(CONFIG_MCU_MPC8349EMITX) += mcu_mpc8349emitx.o ifeq ($(CONFIG_I2C_DEBUG_CHIP),y) EXTRA_CFLAGS += -DDEBUG diff --git a/drivers/i2c/chips/mcu_mpc8349emitx.c b/drivers/i2c/chips/mcu_mpc8349emitx.c deleted file mode 100644 index 82a9bcb..0000000 --- a/drivers/i2c/chips/mcu_mpc8349emitx.c +++ /dev/null @@ -1,209 +0,0 @@ -/* - * Power Management and GPIO expander driver for MPC8349E-mITX-compatible MCU - * - * Copyright (c) 2008 MontaVista Software, Inc. - * - * Author: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - */ - -#include <linux/init.h> -#include <linux/kernel.h> -#include <linux/module.h> -#include <linux/device.h> -#include <linux/mutex.h> -#include <linux/i2c.h> -#include <linux/gpio.h> -#include <linux/of.h> -#include <linux/of_gpio.h> -#include <asm/prom.h> -#include <asm/machdep.h> - -/* - * I don't have specifications for the MCU firmware, I found this register - * and bits positions by the trial&error method. - */ -#define MCU_REG_CTRL 0x20 -#define MCU_CTRL_POFF 0x40 - -#define MCU_NUM_GPIO 2 - -struct mcu { - struct mutex lock; - struct device_node *np; - struct i2c_client *client; - struct of_gpio_chip of_gc; - u8 reg_ctrl; -}; - -static struct mcu *glob_mcu; - -static void mcu_power_off(void) -{ - struct mcu *mcu = glob_mcu; - - pr_info("Sending power-off request to the MCU...\n"); - mutex_lock(&mcu->lock); - i2c_smbus_write_byte_data(glob_mcu->client, MCU_REG_CTRL, - mcu->reg_ctrl | MCU_CTRL_POFF); - mutex_unlock(&mcu->lock); -} - -static void mcu_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) -{ - struct of_gpio_chip *of_gc = to_of_gpio_chip(gc); - struct mcu *mcu = container_of(of_gc, struct mcu, of_gc); - u8 bit = 1 << (4 + gpio); - - mutex_lock(&mcu->lock); - if (val) - mcu->reg_ctrl &= ~bit; - else - mcu->reg_ctrl |= bit; - - i2c_smbus_write_byte_data(mcu->client, MCU_REG_CTRL, mcu->reg_ctrl); - mutex_unlock(&mcu->lock); -} - -static int mcu_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) -{ - mcu_gpio_set(gc, gpio, val); - return 0; -} - -static int mcu_gpiochip_add(struct mcu *mcu) -{ - struct device_node *np; - struct of_gpio_chip *of_gc = &mcu->of_gc; - struct gpio_chip *gc = &of_gc->gc; - int ret; - - np = of_find_compatible_node(NULL, NULL, "fsl,mcu-mpc8349emitx"); - if (!np) - return -ENODEV; - - gc->owner = THIS_MODULE; - gc->label = np->full_name; - gc->can_sleep = 1; - gc->ngpio = MCU_NUM_GPIO; - gc->base = -1; - gc->set = mcu_gpio_set; - gc->direction_output = mcu_gpio_dir_out; - of_gc->gpio_cells = 2; - of_gc->xlate = of_gpio_simple_xlate; - - np->data = of_gc; - mcu->np = np; - - /* - * We don't want to lose the node, its ->data and ->full_name... - * So, if succeeded, we don't put the node here. - */ - ret = gpiochip_add(gc); - if (ret) - of_node_put(np); - return ret; -} - -static int mcu_gpiochip_remove(struct mcu *mcu) -{ - int ret; - - ret = gpiochip_remove(&mcu->of_gc.gc); - if (ret) - return ret; - of_node_put(mcu->np); - - return 0; -} - -static int __devinit mcu_probe(struct i2c_client *client, - const struct i2c_device_id *id) -{ - struct mcu *mcu; - int ret; - - mcu = kzalloc(sizeof(*mcu), GFP_KERNEL); - if (!mcu) - return -ENOMEM; - - mutex_init(&mcu->lock); - mcu->client = client; - i2c_set_clientdata(client, mcu); - - ret = i2c_smbus_read_byte_data(mcu->client, MCU_REG_CTRL); - if (ret < 0) - goto err; - mcu->reg_ctrl = ret; - - ret = mcu_gpiochip_add(mcu); - if (ret) - goto err; - - /* XXX: this is potentially racy, but there is no lock for ppc_md */ - if (!ppc_md.power_off) { - glob_mcu = mcu; - ppc_md.power_off = mcu_power_off; - dev_info(&client->dev, "will provide power-off service\n"); - } - - return 0; -err: - kfree(mcu); - return ret; -} - -static int __devexit mcu_remove(struct i2c_client *client) -{ - struct mcu *mcu = i2c_get_clientdata(client); - int ret; - - if (glob_mcu == mcu) { - ppc_md.power_off = NULL; - glob_mcu = NULL; - } - - ret = mcu_gpiochip_remove(mcu); - if (ret) - return ret; - i2c_set_clientdata(client, NULL); - kfree(mcu); - return 0; -} - -static const struct i2c_device_id mcu_ids[] = { - { "mcu-mpc8349emitx", }, - {}, -}; -MODULE_DEVICE_TABLE(i2c, mcu_ids); - -static struct i2c_driver mcu_driver = { - .driver = { - .name = "mcu-mpc8349emitx", - .owner = THIS_MODULE, - }, - .probe = mcu_probe, - .remove = __devexit_p(mcu_remove), - .id_table = mcu_ids, -}; - -static int __init mcu_init(void) -{ - return i2c_add_driver(&mcu_driver); -} -module_init(mcu_init); - -static void __exit mcu_exit(void) -{ - i2c_del_driver(&mcu_driver); -} -module_exit(mcu_exit); - -MODULE_DESCRIPTION("Power Management and GPIO expander driver for " - "MPC8349E-mITX-compatible MCU"); -MODULE_AUTHOR("Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>"); -MODULE_LICENSE("GPL"); -- 1.5.6.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <20090111165539.GA27223-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>]
* Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ [not found] ` <20090111165539.GA27223-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org> @ 2009-01-13 14:39 ` Kumar Gala 2009-01-13 14:50 ` Jean Delvare 0 siblings, 1 reply; 9+ messages in thread From: Kumar Gala @ 2009-01-13 14:39 UTC (permalink / raw) To: Anton Vorontsov Cc: Jean Delvare, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A, linux-i2c-u79uwXL29TY76Z2rM5mHXA On Jan 11, 2009, at 10:55 AM, Anton Vorontsov wrote: > This patch is used to help Jean Delvare to get rid of drivers/i2c/ > chips/ > directory. The new location suggested by Kumar Gala: as the driver is > 83xx specific it's placed into arch/powerpc/platforms/83xx/. > > Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> > --- > > The same patch but suitable for patch(1). > > arch/powerpc/platforms/83xx/Makefile | 1 + > arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 209 +++++++++++++++ > +++++++++ > arch/powerpc/platforms/Kconfig | 11 ++ > drivers/i2c/chips/Kconfig | 11 -- > drivers/i2c/chips/Makefile | 1 - > drivers/i2c/chips/mcu_mpc8349emitx.c | 209 > ------------------------ > 6 files changed, 221 insertions(+), 221 deletions(-) > create mode 100644 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c > delete mode 100644 drivers/i2c/chips/mcu_mpc8349emitx.c applied - k ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ 2009-01-13 14:39 ` Kumar Gala @ 2009-01-13 14:50 ` Jean Delvare 0 siblings, 0 replies; 9+ messages in thread From: Jean Delvare @ 2009-01-13 14:50 UTC (permalink / raw) To: Kumar Gala; +Cc: linuxppc-dev, linux-i2c On Tue, 13 Jan 2009 08:39:37 -0600, Kumar Gala wrote: > > On Jan 11, 2009, at 10:55 AM, Anton Vorontsov wrote: > > > This patch is used to help Jean Delvare to get rid of drivers/i2c/ > > chips/ > > directory. The new location suggested by Kumar Gala: as the driver is > > 83xx specific it's placed into arch/powerpc/platforms/83xx/. > > > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > --- > > > > The same patch but suitable for patch(1). > > > > arch/powerpc/platforms/83xx/Makefile | 1 + > > arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 209 +++++++++++++++ > > +++++++++ > > arch/powerpc/platforms/Kconfig | 11 ++ > > drivers/i2c/chips/Kconfig | 11 -- > > drivers/i2c/chips/Makefile | 1 - > > drivers/i2c/chips/mcu_mpc8349emitx.c | 209 > > ------------------------ > > 6 files changed, 221 insertions(+), 221 deletions(-) > > create mode 100644 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c > > delete mode 100644 drivers/i2c/chips/mcu_mpc8349emitx.c > > applied Great, thanks Anton and Kumar! -- Jean Delvare ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ [not found] ` <20090111165136.GA26096-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org> 2009-01-11 16:55 ` Anton Vorontsov @ 2009-01-11 17:10 ` Jean Delvare [not found] ` <20090111181055.31611474-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> 2009-01-12 15:10 ` Kumar Gala 1 sibling, 2 replies; 9+ messages in thread From: Jean Delvare @ 2009-01-11 17:10 UTC (permalink / raw) To: Anton Vorontsov Cc: Kumar Gala, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A Hi Anton, On Sun, 11 Jan 2009 19:51:36 +0300, Anton Vorontsov wrote: > This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ > directory. The new location suggested by Kumar Gala: as the driver is > 83xx specific it's placed into arch/powerpc/platforms/83xx/. > > Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> Thanks for doing this. Do you expect me to take this patch in my i2c tree, or will it go in some powerpc tree? -- Jean Delvare ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20090111181055.31611474-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>]
* Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ [not found] ` <20090111181055.31611474-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> @ 2009-01-11 17:24 ` Anton Vorontsov [not found] ` <20090111172410.GA7106-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org> 2009-01-12 15:10 ` Kumar Gala 1 sibling, 1 reply; 9+ messages in thread From: Anton Vorontsov @ 2009-01-11 17:24 UTC (permalink / raw) To: Jean Delvare Cc: Kumar Gala, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A On Sun, Jan 11, 2009 at 06:10:55PM +0100, Jean Delvare wrote: > Hi Anton, > > On Sun, 11 Jan 2009 19:51:36 +0300, Anton Vorontsov wrote: > > This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ > > directory. The new location suggested by Kumar Gala: as the driver is > > 83xx specific it's placed into arch/powerpc/platforms/83xx/. > > > > Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> > > Thanks for doing this. Do you expect me to take this patch in my i2c > tree, or will it go in some powerpc tree? As the patch adds some code to arch/powerpc/, I believe Kumar would want to merge it into his powerpc tree. In that case I think we'll need your Acked-by line for formality. But let's wait for Kumar's decision. Thanks, -- Anton Vorontsov email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org irc://irc.freenode.net/bd2 ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20090111172410.GA7106-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>]
* Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ [not found] ` <20090111172410.GA7106-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org> @ 2009-01-11 18:52 ` Jean Delvare 0 siblings, 0 replies; 9+ messages in thread From: Jean Delvare @ 2009-01-11 18:52 UTC (permalink / raw) To: avorontsov-hkdhdckH98+B+jHODAdFcQ Cc: Kumar Gala, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A On Sun, 11 Jan 2009 20:24:10 +0300, Anton Vorontsov wrote: > On Sun, Jan 11, 2009 at 06:10:55PM +0100, Jean Delvare wrote: > > Hi Anton, > > > > On Sun, 11 Jan 2009 19:51:36 +0300, Anton Vorontsov wrote: > > > This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ > > > directory. The new location suggested by Kumar Gala: as the driver is > > > 83xx specific it's placed into arch/powerpc/platforms/83xx/. > > > > > > Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> > > > > Thanks for doing this. Do you expect me to take this patch in my i2c > > tree, or will it go in some powerpc tree? > > As the patch adds some code to arch/powerpc/, I believe Kumar would > want to merge it into his powerpc tree. In that case I think we'll > need your Acked-by line for formality. Sure: Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> > But let's wait for Kumar's decision. -- Jean Delvare ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ [not found] ` <20090111181055.31611474-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> 2009-01-11 17:24 ` Anton Vorontsov @ 2009-01-12 15:10 ` Kumar Gala 1 sibling, 0 replies; 9+ messages in thread From: Kumar Gala @ 2009-01-12 15:10 UTC (permalink / raw) To: Jean Delvare Cc: Anton Vorontsov, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A On Jan 11, 2009, at 11:10 AM, Jean Delvare wrote: > Hi Anton, > > On Sun, 11 Jan 2009 19:51:36 +0300, Anton Vorontsov wrote: >> This patch is used to help Jean Delvare to get rid of drivers/i2c/ >> chips/ >> directory. The new location suggested by Kumar Gala: as the driver is >> 83xx specific it's placed into arch/powerpc/platforms/83xx/. >> >> Signed-off-by: Anton Vorontsov <avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org> > > Thanks for doing this. Do you expect me to take this patch in my i2c > tree, or will it go in some powerpc tree? I'll pick this up. - k ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ 2009-01-11 17:10 ` Jean Delvare [not found] ` <20090111181055.31611474-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> @ 2009-01-12 15:10 ` Kumar Gala 1 sibling, 0 replies; 9+ messages in thread From: Kumar Gala @ 2009-01-12 15:10 UTC (permalink / raw) To: Jean Delvare; +Cc: linuxppc-dev, linux-i2c On Jan 11, 2009, at 11:10 AM, Jean Delvare wrote: > Hi Anton, > > On Sun, 11 Jan 2009 19:51:36 +0300, Anton Vorontsov wrote: >> This patch is used to help Jean Delvare to get rid of drivers/i2c/ >> chips/ >> directory. The new location suggested by Kumar Gala: as the driver is >> 83xx specific it's placed into arch/powerpc/platforms/83xx/. >> >> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > Thanks for doing this. Do you expect me to take this patch in my i2c > tree, or will it go in some powerpc tree? I'll pick this up. - k ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-01-13 14:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-11 16:51 [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/ Anton Vorontsov
[not found] ` <20090111165136.GA26096-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-01-11 16:55 ` Anton Vorontsov
[not found] ` <20090111165539.GA27223-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-01-13 14:39 ` Kumar Gala
2009-01-13 14:50 ` Jean Delvare
2009-01-11 17:10 ` Jean Delvare
[not found] ` <20090111181055.31611474-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-01-11 17:24 ` Anton Vorontsov
[not found] ` <20090111172410.GA7106-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2009-01-11 18:52 ` Jean Delvare
2009-01-12 15:10 ` Kumar Gala
2009-01-12 15:10 ` Kumar Gala
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox