Re: Move eeprom drivers to drivers/misc/eeprom

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Wolfram,

On Tue, 20 Jan 2009 11:22:58 +0100, Wolfram Sang wrote:
> As the directory drivers/i2c/chips is going away, we needed a new place
> for the I2C eeprom drivers. After some discussion, the idea of putting
> them into a directory drivers/misc/eeprom was favoured. David Brownell
> added that his SPI eeprom driver could go there as well.
> 
> This patch series carries out the proposal and while at it, moves an
> eeprom driver which was already in drivers/misc to the new location.
> 
> No code inside the drivers was changed and everything was
> succesfully compile-tested.

Thanks a lot for doing this. I've applied all 4 patches.

Things which I think need to be improved on top of your patches:

* Dependencies. The at24 and eeprom drivers should depend on I2C and the
at25 driver should depend on SPI. They did beforehand, thanks to
menu-level dependencies, there's no reason to change this. Should
probably be merged into your patches so that there is no regression.

This might be a good rationale to move the "Misc devices" entry at the
end of the menu, so that users can select the dependencies first.

* Symbol names. At the moment we have:

CONFIG_AT24
CONFIG_SPI_AT25
CONFIG_SENSORS_EEPROM
CONFIG_EEPROM_93CX6

I want to get rid of "SENSORS", at least. But maybe it is the right
time to make the symbol names more consistent? For example:

CONFIG_EEPROM_AT24
CONFIG_EEPROM_AT25
CONFIG_EEPROM_LEGACY
CONFIG_EEPROM_93CX6

This gives some more work on "make oldconfig" but I think it's worth
it. Are there any objections to this change?

Thanks,
-- 
Jean Delvare