From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] i2c: add missing KERN_* constants to printks Date: Mon, 9 Feb 2009 11:27:18 +0100 Message-ID: <20090209112718.5ddf68db@hyperion.delvare> References: <498C3EEA.5060508@suse.de> <20090208000553.059a0732@hyperion.delvare> <498EDA18.1090300@f-seidel.de> <20090208144751.46184041@hyperion.delvare> <20090209083537.GA3438@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090209083537.GA3438-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Frank Seidel , Frank Seidel , linux kernel , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , ukleinek-jNDFPZUTrfROceuj71AUlABBhMqQ4zRThC4ANOJQIlc@public.gmane.org, Frans Pop , Geert Uytterhoeven List-Id: linux-i2c@vger.kernel.org On Mon, 9 Feb 2009 09:35:37 +0100, Wolfram Sang wrote: > > I mean the (first) printk in the loop, not the last printk in this > > function. So what I am suggesting is: > > > > + printk(KERN_DEBUG); > > for (i = 0; i < i2c->irqlogidx; i++) > > printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]); > > printk("\n"); > > Hmm, I was told (by Jean ;)) that every printk should end with newline, > otherwise it might get interrupted with other output -> mess. Correct, however the code was already wrong before Frank's patch, and his patch is fixing a different problem. So I don't have any problem with this, this can be fixed in a later patch if anybody cares. -- Jean Delvare