Re: [PATCH 1/2] i2c: add "reset" sysfs entry for adapters.

[Rodolfo Giometti <giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org>]

On Mon, Feb 09, 2009 at 02:55:46PM +0000, Ben Dooks wrote:
> On Fri, Feb 06, 2009 at 04:23:17PM +0100, Rodolfo Giometti wrote:
> > It could happen that an i2c adapter may lock the bus due due
> > electrical problems, so the user may recover this stale state by using:
> > 
> > 	$ echo 1 > /sys/class/i2c-adapter/i2c-0/reset
> > 
> > Signed-off-by: Rodolfo Giometti <giometti-k2GhghHVRtY@public.gmane.org>
> 
> There doesn't seem to be any locking to stop issuing a reset during
> an extant transaction... should the controller driver deal with
> cancelling any outstanding transactions?

I think this should be done inside each adapter driver since it's
an adapter specific issue.

If you see next patch of this patchset you can see that the adapter
i2c-pxa aborts any transfer currently under way during reset.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver                          giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti