From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: dsilvers-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH] I2C: Rename struct s3c2410_platform_i2c to s3c_platform_i2c
Date: Thu, 12 Feb 2009 15:05:27 +0100 [thread overview]
Message-ID: <20090212150527.2d8031ad@hyperion.delvare> (raw)
In-Reply-To: <1234446570.9457.28.camel@petitemort>
On Thu, 12 Feb 2009 13:49:30 +0000, Daniel Silverstone wrote:
> The I2C driver currently known as i2c-s3c2410 is now used by
> several different s3cXXXX SoCs. As such, this patch renames the
> platform data to be SoC agnostic.
>
> Signed-Off-By: Simtec Linux Team <linux-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>
> Signed-Off-By: Daniel Silverstone <dsilvers-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org>
>
> ---
> arch/arm/mach-s3c2410/mach-bast.c | 2 +-
> arch/arm/mach-s3c2410/mach-n30.c | 2 +-
> arch/arm/mach-s3c2412/mach-jive.c | 2 +-
> arch/arm/plat-s3c/dev-i2c0.c | 8 ++++----
> arch/arm/plat-s3c/dev-i2c1.c | 8 ++++----
> arch/arm/plat-s3c/include/plat/iic.h | 8 ++++----
> drivers/i2c/busses/i2c-s3c2410.c | 6 +++---
> 7 files changed, 18 insertions(+), 18 deletions(-)
This is Ben's call, not mine, but I tend to discourage that kind of
changes. For one thing, they cost more than then bring. And for
another, they may need to be reverted if incompatible hardware appears
in the future.
Personally, I read "s3c2410" in these structure names as "S3C 2410 and
compatible", so it looks perfectly right to me, I don't see this as
something which needs to be changed.
--
Jean Delvare
next prev parent reply other threads:[~2009-02-12 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 13:49 [PATCH] I2C: Rename struct s3c2410_platform_i2c to s3c_platform_i2c Daniel Silverstone
2009-02-12 14:05 ` Jean Delvare [this message]
[not found] ` <20090212150527.2d8031ad-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-12 14:24 ` Daniel Silverstone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212150527.2d8031ad@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dsilvers-Y5A6D6n0/KfQXOPxS62xeg@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox