From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
costa-nrw9SyMmU14AvxtiuMwx3w@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH] i2c/pca: add PCA9665 support
Date: Tue, 24 Feb 2009 09:36:03 +0100 [thread overview]
Message-ID: <20090224093603.66d681e1@hyperion.delvare> (raw)
In-Reply-To: <20090221130354.GB16774-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Hi Wolfram,
On Sat, 21 Feb 2009 14:03:54 +0100, Wolfram Sang wrote:
>
> This patch adds support for the PCA9665 I2C controller, originally tested and
> posted by Marco Aurelio da Costa. As he did not resubmit the patch after the
> final review five months ago, I picked it up, made it apply to latest linus-git
> and removed the minor coding-style issues.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
>
> It still works with my PCA9564, so it surely didn't break anything.
>
> Marco, if you are still around, it would be nice to get a signed-off from you!
> (I didn't change any code except adding two "\n" and one " " to debug strings)
>
> Jean, Ben, do you think we can handle it this way? I'd like to see this
> included before the last known working state gets too far off from mainline.
>
> drivers/i2c/algos/i2c-algo-pca.c | 180 +++++++++++++++++++++++++++++++---
> drivers/i2c/busses/Kconfig | 8 -
> drivers/i2c/busses/i2c-pca-isa.c | 14 +-
> drivers/i2c/busses/i2c-pca-platform.c | 9 -
> include/linux/i2c-algo-pca.h | 33 +++++-
> 5 files changed, 216 insertions(+), 28 deletions(-)
Unfortunately I don't have the time to make a full review of this
patch. I don't want to delay its inclusion though, so unless someone
volunteers to review it, I will apply it as is. If any problem is later
reported, you'll have to fix it.
--
Jean Delvare
next prev parent reply other threads:[~2009-02-24 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 13:03 [PATCH] i2c/pca: add PCA9665 support Wolfram Sang
[not found] ` <20090221130354.GB16774-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-02-24 8:36 ` Jean Delvare [this message]
[not found] ` <20090224093603.66d681e1-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-24 8:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224093603.66d681e1@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=costa-nrw9SyMmU14AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox