Re: [PATCH] i2c: Adapter timeout is in jiffies

Re: [PATCH] i2c: Adapter timeout is in jiffies

[Lennert Buytenhek]

On Sun, Feb 22, 2009 at 04:07:05PM +0100, Jean Delvare wrote:

> From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Subject: i2c: Adapter timeout is in jiffies
> 
> i2c_adapter.timeout is in jiffies. Fix all drivers which thought
> otherwise. It didn't really matter as long as the value was only used
> inside the driver, but soon i2c-core will use it too so it must have
> the proper unit.
> 
> Note: for the i2c-mpc driver, this fixes a bug in polling mode.
> Timeout would trigger after 1 jiffy, which is most probably not what
> the author wanted.
> 
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Clifford Wolf <clifford-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org>
> Cc: Sean MacLennan <smaclennan-Qtffpm9i2AVWk0Htik3J/w@public.gmane.org>
> Cc: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
> Cc: Lennert Buytenhek <kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org>
> Cc: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
> Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-ibm_iic.c |    6 +++---
>  drivers/i2c/busses/i2c-iop3xx.c  |    2 +-
>  drivers/i2c/busses/i2c-mpc.c     |    4 ++--
>  drivers/i2c/busses/i2c-mv64xxx.c |    7 +++----
>  drivers/i2c/busses/i2c-pca-isa.c |    2 +-
>  5 files changed, 10 insertions(+), 11 deletions(-)

The i2c-mv64xxx part:

Acked-by: Lennert Buytenhek <buytenh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>

Although I wonder if we shouldn't move away from expressing time
intervals in jiffies.

Re: [PATCH] i2c: Adapter timeout is in jiffies

[Jean Delvare]

Hi Lennert,

On Sun, 22 Feb 2009 16:20:59 +0100, Lennert Buytenhek wrote:
> On Sun, Feb 22, 2009 at 04:07:05PM +0100, Jean Delvare wrote:
> 
> > From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> > Subject: i2c: Adapter timeout is in jiffies
> > 
> > i2c_adapter.timeout is in jiffies. Fix all drivers which thought
> > otherwise. It didn't really matter as long as the value was only used
> > inside the driver, but soon i2c-core will use it too so it must have
> > the proper unit.
> > 
> > Note: for the i2c-mpc driver, this fixes a bug in polling mode.
> > Timeout would trigger after 1 jiffy, which is most probably not what
> > the author wanted.
> > 
> > Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> > Cc: Clifford Wolf <clifford-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org>
> > Cc: Sean MacLennan <smaclennan-Qtffpm9i2AVWk0Htik3J/w@public.gmane.org>
> > Cc: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
> > Cc: Lennert Buytenhek <kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org>
> > Cc: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> > Cc: Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
> > Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> >  drivers/i2c/busses/i2c-ibm_iic.c |    6 +++---
> >  drivers/i2c/busses/i2c-iop3xx.c  |    2 +-
> >  drivers/i2c/busses/i2c-mpc.c     |    4 ++--
> >  drivers/i2c/busses/i2c-mv64xxx.c |    7 +++----
> >  drivers/i2c/busses/i2c-pca-isa.c |    2 +-
> >  5 files changed, 10 insertions(+), 11 deletions(-)
> 
> The i2c-mv64xxx part:
> 
> Acked-by: Lennert Buytenhek <buytenh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>

Thanks.

> Although I wonder if we shouldn't move away from expressing time
> intervals in jiffies.

Why? This is what time_after() and wait_event_interruptible_timeout()
want, so this is the most efficient way (as discussed recently [1]).

[1] http://marc.info/?l=linux-i2c&m=123507862624484&w=2

-- 
Jean Delvare

Re: [PATCH] i2c: Adapter timeout is in jiffies

[Mark A. Greer]

On Sun, Feb 22, 2009 at 04:07:05PM +0100, Jean Delvare wrote:
> From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Subject: i2c: Adapter timeout is in jiffies
> 
> i2c_adapter.timeout is in jiffies. Fix all drivers which thought
> otherwise. It didn't really matter as long as the value was only used
> inside the driver, but soon i2c-core will use it too so it must have
> the proper unit.
> 
> Note: for the i2c-mpc driver, this fixes a bug in polling mode.
> Timeout would trigger after 1 jiffy, which is most probably not what
> the author wanted.
> 
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Clifford Wolf <clifford-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org>
> Cc: Sean MacLennan <smaclennan-Qtffpm9i2AVWk0Htik3J/w@public.gmane.org>
> Cc: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
> Cc: Lennert Buytenhek <kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org>
> Cc: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
> Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-ibm_iic.c |    6 +++---
>  drivers/i2c/busses/i2c-iop3xx.c  |    2 +-
>  drivers/i2c/busses/i2c-mpc.c     |    4 ++--
>  drivers/i2c/busses/i2c-mv64xxx.c |    7 +++----
>  drivers/i2c/busses/i2c-pca-isa.c |    2 +-
>  5 files changed, 10 insertions(+), 11 deletions(-)

For the i2c-mv64xxx.c part:

Acked-by: Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>

Re: [PATCH] i2c: Adapter timeout is in jiffies

[Sean MacLennan]

On Sun, 22 Feb 2009 16:07:05 +0100
"Jean Delvare" <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:

> From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Subject: i2c: Adapter timeout is in jiffies
> 
> i2c_adapter.timeout is in jiffies. Fix all drivers which thought
> otherwise. It didn't really matter as long as the value was only used
> inside the driver, but soon i2c-core will use it too so it must have
> the proper unit.
> 
> Note: for the i2c-mpc driver, this fixes a bug in polling mode.
> Timeout would trigger after 1 jiffy, which is most probably not what
> the author wanted.
> 
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Clifford Wolf <clifford-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org>
> Cc: Sean MacLennan <smaclennan-Qtffpm9i2AVWk0Htik3J/w@public.gmane.org>
> Cc: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
> Cc: Lennert Buytenhek <kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org>
> Cc: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
> Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-ibm_iic.c |    6 +++---
>  drivers/i2c/busses/i2c-iop3xx.c  |    2 +-
>  drivers/i2c/busses/i2c-mpc.c     |    4 ++--
>  drivers/i2c/busses/i2c-mv64xxx.c |    7 +++----
>  drivers/i2c/busses/i2c-pca-isa.c |    2 +-
>  5 files changed, 10 insertions(+), 11 deletions(-)

i2c-ibm_iic.c:

Acked-by: Sean MacLennan <smaclennan-Qtffpm9i2AVWk0Htik3J/w@public.gmane.org>

Cheers,
   Sean