From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean MacLennan Subject: Re: [PATCH] i2c: Adapter timeout is in jiffies Date: Tue, 24 Feb 2009 20:12:08 -0500 Message-ID: <20090224201208.32c419ad@lappy.seanm.ca> References: <20090222160705.63563a14@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090222160705.63563a14-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: Linux I2C , Clifford Wolf , Sean MacLennan , Stefan Roese , Lennert Buytenhek , Dan Williams , Grant Likely , "Mark A. Greer" , Wolfram Sang List-Id: linux-i2c@vger.kernel.org On Sun, 22 Feb 2009 16:07:05 +0100 "Jean Delvare" wrote: > From: Jean Delvare > Subject: i2c: Adapter timeout is in jiffies > > i2c_adapter.timeout is in jiffies. Fix all drivers which thought > otherwise. It didn't really matter as long as the value was only used > inside the driver, but soon i2c-core will use it too so it must have > the proper unit. > > Note: for the i2c-mpc driver, this fixes a bug in polling mode. > Timeout would trigger after 1 jiffy, which is most probably not what > the author wanted. > > Signed-off-by: Jean Delvare > Cc: Clifford Wolf > Cc: Sean MacLennan > Cc: Stefan Roese > Cc: Lennert Buytenhek > Cc: Dan Williams > Cc: Grant Likely > Cc: Mark A. Greer > Cc: Wolfram Sang > --- > drivers/i2c/busses/i2c-ibm_iic.c | 6 +++--- > drivers/i2c/busses/i2c-iop3xx.c | 2 +- > drivers/i2c/busses/i2c-mpc.c | 4 ++-- > drivers/i2c/busses/i2c-mv64xxx.c | 7 +++---- > drivers/i2c/busses/i2c-pca-isa.c | 2 +- > 5 files changed, 10 insertions(+), 11 deletions(-) i2c-ibm_iic.c: Acked-by: Sean MacLennan Cheers, Sean