From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH] Added driver for ISL29003 ambient light sensor Date: Thu, 26 Feb 2009 10:06:51 +0100 Message-ID: <20090226090651.GA20531@buzzloop.caiaq.de> References: <20090225212119.67402391@hyperion.delvare> <1235606248-13004-1-git-send-email-daniel@caiaq.de> <20090226094857.50d0710d@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090226094857.50d0710d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Cameron List-Id: linux-i2c@vger.kernel.org On Thu, Feb 26, 2009 at 09:48:57AM +0100, Jean Delvare wrote: > On Thu, 26 Feb 2009 00:57:28 +0100, Daniel Mack wrote: > > This patch adds a driver for Intersil's ISL29003 ambient light sensor > > device plus some documentation. Inspired by tsl2550.c, a driver for a > > similar device. > > > > Signed-off-by: Daniel Mack > > --- > > Moved the driver to drivers/hwmon > > > > Documentation/hwmon/isl29003 | 62 +++++ > > drivers/hwmon/Kconfig | 10 + > > drivers/hwmon/Makefile | 1 + > > drivers/hwmon/isl29003.c | 517 ++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 590 insertions(+), 0 deletions(-) > > create mode 100644 Documentation/hwmon/isl29003 > > create mode 100644 drivers/hwmon/isl29003.c > > Still no luck, sorry. Light sensors have nothing to do with hardware > monitoring. I decided to put it there because of config SENSORS_APPLESMC tristate "Apple SMC (Motion sensor, light sensor, keyboard backlight)" > I think we need a new subsystem for light sensors. drivers/light maybe? > Or maybe this fits into Jonathan Cameron's industrial I/O subsystem. > Jonathan, what do you think? If not, maybe a more general subsystem for > various sensor types (light, pressure, noise, whatever.) > > Me, I don't really care where these drivers go as long as it's not in > drivers/i2c/chips. I don't care eighter - who's deciding it then? Just let me know where you want it and I'll post a new patch. Thanks, Daniel