Re: [PATCH] Added driver for ISL29003 ambient light sensor

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Thu, 26 Feb 2009 10:06:51 +0100, Daniel Mack wrote:
> On Thu, Feb 26, 2009 at 09:48:57AM +0100, Jean Delvare wrote:
> > On Thu, 26 Feb 2009 00:57:28 +0100, Daniel Mack wrote:
> > > This patch adds a driver for Intersil's ISL29003 ambient light sensor
> > > device plus some documentation. Inspired by tsl2550.c, a driver for a
> > > similar device.
> > > 
> > > Signed-off-by: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
> > > ---
> > > Moved the driver to drivers/hwmon
> > > 
> > >  Documentation/hwmon/isl29003 |   62 +++++
> > >  drivers/hwmon/Kconfig        |   10 +
> > >  drivers/hwmon/Makefile       |    1 +
> > >  drivers/hwmon/isl29003.c     |  517 ++++++++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 590 insertions(+), 0 deletions(-)
> > >  create mode 100644 Documentation/hwmon/isl29003
> > >  create mode 100644 drivers/hwmon/isl29003.c
> > 
> > Still no luck, sorry. Light sensors have nothing to do with hardware
> > monitoring.
> 
> I decided to put it there because of 
> 
> config SENSORS_APPLESMC
>         tristate "Apple SMC (Motion sensor, light sensor, keyboard
> 	backlight)"

That driver is in hwmon for the motion sensor, and the temperature
sensors, not the light sensor. That being said I was never happy to see
these accelerometer drivers in hwmon, they don't have much in common
with traditional hardware monitoring chips so they should have their
own subsystem. Or they could go to drivers/mfd as these chips usually
have many functions (as outlined by the above summary line.)

-- 
Jean Delvare