From: Felipe Balbi <me@felipebalbi.com>
To: Ari Kauppi <Ext-Ari.Kauppi@nokia.com>
Cc: linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] I2C: Call request_irq with IRQF_DISABLED
Date: Thu, 5 Mar 2009 21:35:06 +0200 [thread overview]
Message-ID: <20090305193505.GA32746@frodo> (raw)
In-Reply-To: <1236261264-16053-1-git-send-email-Ext-Ari.Kauppi@nokia.com>
On Thu, Mar 05, 2009 at 03:54:24PM +0200, Ari Kauppi wrote:
> I have observed some Spurious IRQ's for I2C1 when all kernel hacking options
> (and thus LOCKDEP) are disabled.
>
> Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help
> but IRQF_DISABLED is needed for proper behaviour.
>
> Signed-off-by: Ari Kauppi <Ext-Ari.Kauppi@nokia.com>
This driver should be in sync with mainline, the only missing commit is
commit 3487568e15df6e133f5f55779dec614dbeb68a99
Author: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Date: Tue Nov 25 13:03:46 2008 +0200
i2c: i2c-omap: Fix BUFSTAT_REG reading
The number of bytes to be received is read from wrong
place with all OMAPs with highspeed I2C support,
which involves a FIFO and BUFSTAT_REG. It is the 6
bits starting from the bit 8 in the BUFSTAT_REG
that indicate this amount of bytes to be read.
Moreover, only the 6 LSB:s are relevant for the
TXSTAT field.
Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
That and this one should be going via linux-i2c mainling list. Could you
send Eero's patch and yours to Jean Delvare (i2c maintainer) ? Please
keep linux-omap in the loop.
That said, this makes sense and avoids that we get interrupts while
handling a previous interrupt.
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
--
balbi
next prev parent reply other threads:[~2009-03-05 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 13:54 [PATCH] I2C: Call request_irq with IRQF_DISABLED Ari Kauppi
2009-03-05 19:35 ` Felipe Balbi [this message]
2009-03-05 20:03 ` Jean Delvare
2009-03-05 20:15 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305193505.GA32746@frodo \
--to=me@felipebalbi.com \
--cc=Ext-Ari.Kauppi@nokia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox