public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c: Initialise Samsung I2C controller early
@ 2009-02-26 16:29 Mark Brown
       [not found] ` <1235665762-20400-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2009-02-26 16:29 UTC (permalink / raw)
  To: Ben Dooks; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Mark Brown

This is required in order to ensure that core system devices such as
voltage regulators attached via I2C are avaiable early in boot.

Signed-off-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
---
 drivers/i2c/busses/i2c-s3c2410.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 5b7f956..91f6a1e 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1018,14 +1018,13 @@ static int __init i2c_adap_s3c_init(void)
 
 	return ret;
 }
+subsys_initcall(i2c_adap_s3c_init);
 
 static void __exit i2c_adap_s3c_exit(void)
 {
 	platform_driver_unregister(&s3c2410_i2c_driver);
 	platform_driver_unregister(&s3c2440_i2c_driver);
 }
-
-module_init(i2c_adap_s3c_init);
 module_exit(i2c_adap_s3c_exit);
 
 MODULE_DESCRIPTION("S3C24XX I2C Bus driver");
-- 
1.6.1.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: Initialise Samsung I2C controller early
       [not found] ` <1235665762-20400-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
@ 2009-03-05 20:13   ` Ben Dooks
  2009-03-31 23:02   ` Ben Dooks
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2009-03-05 20:13 UTC (permalink / raw)
  To: Mark Brown; +Cc: Ben Dooks, linux-i2c-u79uwXL29TY76Z2rM5mHXA

On Thu, Feb 26, 2009 at 04:29:22PM +0000, Mark Brown wrote:
> This is required in order to ensure that core system devices such as
> voltage regulators attached via I2C are avaiable early in boot.

Ok, will try and test soon and add to my -next tree.
 
> Signed-off-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 5b7f956..91f6a1e 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1018,14 +1018,13 @@ static int __init i2c_adap_s3c_init(void)
>  
>  	return ret;
>  }
> +subsys_initcall(i2c_adap_s3c_init);
>  
>  static void __exit i2c_adap_s3c_exit(void)
>  {
>  	platform_driver_unregister(&s3c2410_i2c_driver);
>  	platform_driver_unregister(&s3c2440_i2c_driver);
>  }
> -
> -module_init(i2c_adap_s3c_init);
>  module_exit(i2c_adap_s3c_exit);
>  
>  MODULE_DESCRIPTION("S3C24XX I2C Bus driver");
> -- 
> 1.6.1.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: Initialise Samsung I2C controller early
       [not found] ` <1235665762-20400-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
  2009-03-05 20:13   ` Ben Dooks
@ 2009-03-31 23:02   ` Ben Dooks
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2009-03-31 23:02 UTC (permalink / raw)
  To: Mark Brown; +Cc: Ben Dooks, linux-i2c-u79uwXL29TY76Z2rM5mHXA

On Thu, Feb 26, 2009 at 04:29:22PM +0000, Mark Brown wrote:
> This is required in order to ensure that core system devices such as
> voltage regulators attached via I2C are avaiable early in boot.

applied, subsys_initcall works for modules as well as builtin code.
 
> Signed-off-by: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 5b7f956..91f6a1e 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1018,14 +1018,13 @@ static int __init i2c_adap_s3c_init(void)
>  
>  	return ret;
>  }
> +subsys_initcall(i2c_adap_s3c_init);
>  
>  static void __exit i2c_adap_s3c_exit(void)
>  {
>  	platform_driver_unregister(&s3c2410_i2c_driver);
>  	platform_driver_unregister(&s3c2440_i2c_driver);
>  }
> -
> -module_init(i2c_adap_s3c_init);
>  module_exit(i2c_adap_s3c_exit);
>  
>  MODULE_DESCRIPTION("S3C24XX I2C Bus driver");
> -- 
> 1.6.1.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-03-31 23:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-26 16:29 [PATCH] i2c: Initialise Samsung I2C controller early Mark Brown
     [not found] ` <1235665762-20400-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2009-03-05 20:13   ` Ben Dooks
2009-03-31 23:02   ` Ben Dooks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox