Re: [PATCH] Added driver for ISL29003 ambient light sensor

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Daniel,

On Fri, 6 Mar 2009 17:00:42 +0100, Daniel Mack wrote:
> On Thu, Feb 26, 2009 at 09:48:57AM +0100, Jean Delvare wrote:
> > On Thu, 26 Feb 2009 00:57:28 +0100, Daniel Mack wrote:
> > > This patch adds a driver for Intersil's ISL29003 ambient light sensor
> > > device plus some documentation. Inspired by tsl2550.c, a driver for a
> > > similar device.
> > > 
> > > Signed-off-by: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>
> > > ---
> > > Moved the driver to drivers/hwmon
> > > 
> > >  Documentation/hwmon/isl29003 |   62 +++++
> > >  drivers/hwmon/Kconfig        |   10 +
> > >  drivers/hwmon/Makefile       |    1 +
> > >  drivers/hwmon/isl29003.c     |  517 ++++++++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 590 insertions(+), 0 deletions(-)
> > >  create mode 100644 Documentation/hwmon/isl29003
> > >  create mode 100644 drivers/hwmon/isl29003.c
> > 
> > Still no luck, sorry. Light sensors have nothing to do with hardware
> > monitoring.
> 
> Sorry to annoy you again with that topic, but I'm a little stuck here.
> The 'industrial I/O' thread I was pointed to seems to be orphaned and I
> didn't get much response on the LKML about alternatives either.

Sorry for the long silence, I have been pretty busy these last days,
and was also hopping for a comment from Jonathan. The industrial I/O
subsystem isn't orphaned, I am fairly certain it will be merged some
day, but it could take some time.

> As hwmon still appears the best existing place for such a driver to live
> in, could we just take it and move it somewhere else as soon somebody
> comes along with some better idea? I'd just like to avoid it being lost,
> and every other approach does not feel very productive currently.

I agree that it doesn't make sense to wait for the industrial I/O
subsystem to be merged. But I also do not want to put in drivers/hwmon
drivers which do not really belong there. So I'd either go the way you
proposed already (drivers/sensors for non-hwmon sensor drivers) or
simply put your driver in drivers/misc if this is only meant as a
temporary home until the industrial I/O subsystem is merged.

-- 
Jean Delvare