From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Scott James Remnant <scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 22/31] i2c: Auto-load i2c_dev module when device opened.
Date: Tue, 10 Mar 2009 17:56:12 +0100 [thread overview]
Message-ID: <20090310175612.7e5b8272@hyperion.delvare> (raw)
In-Reply-To: <c9e8ec654db2ee34fc9fda29222aee9dd085ddaa.1236702228.git.scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Scott,
Your clock is off by a significant number of days, isn't it?
On Mon, 2 Mar 2009 18:41:51 +0000, Scott James Remnant wrote:
> The i2c_dev module is missing the char-major-89-* alias that would cause
> it to be auto-loaded when a device of that type is opened. This patch
> adds the alias.
Why not, however this is pretty pointless nowadays as /dev nodes tend
to be created dynamically by udev, so there is no way i2c-dev will
auto-load.
> Signed-off-by: Scott James Remnant <scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> Signed-off-by: Tim Gardner <tim.gardner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
> drivers/i2c/i2c-dev.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index 7e13d2d..f3f83ba 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -618,6 +618,7 @@ MODULE_AUTHOR("Frodo Looijaard <frodol-B0qZmFHriGg@public.gmane.org> and "
> "Simon G. Vogl <simon-nD9nYVNVf00W+b/DJNNodF6hYfS7NtTn@public.gmane.org>");
> MODULE_DESCRIPTION("I2C /dev entries driver");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS_CHARDEV_MAJOR(I2C_MAJOR);
>
> module_init(i2c_dev_init);
> module_exit(i2c_dev_exit);
--
Jean Delvare
next prev parent reply other threads:[~2009-03-10 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1236702228.git.scott@canonical.com>
[not found] ` <cover.1236702228.git.scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2009-03-02 18:41 ` [PATCH 22/31] i2c: Auto-load i2c_dev module when device opened Scott James Remnant
[not found] ` <c9e8ec654db2ee34fc9fda29222aee9dd085ddaa.1236702228.git.scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2009-03-10 16:56 ` Jean Delvare [this message]
[not found] ` <20090310175612.7e5b8272-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-03-10 17:00 ` Scott James Remnant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310175612.7e5b8272@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox