From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] Added driver for ISL29003 ambient light sensor Date: Wed, 11 Mar 2009 09:32:34 -0700 Message-ID: <20090311093234.7e8e5416.akpm@linux-foundation.org> References: <20090306181409.GA20135@buzzloop.caiaq.de> <20090307115449.32f0ab26@hyperion.delvare> <20090307120631.GA25276@buzzloop.caiaq.de> <20090307130818.367bcaad@hyperion.delvare> <20090309210901.GC31367@buzzloop.caiaq.de> <49B666F9.50209@cam.ac.uk> <20090310151542.GE9564@buzzloop.caiaq.de> <49B6A843.3090902@cam.ac.uk> <20090311003155.GB21160@buzzloop.caiaq.de> <20090310212826.7d8b3d4e.akpm@linux-foundation.org> <20090311083252.GB25824@buzzloop.caiaq.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090311083252.GB25824-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Mack Cc: Jonathan Cameron , Jean Delvare , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Wed, 11 Mar 2009 09:32:52 +0100 Daniel Mack wrote: > On Tue, Mar 10, 2009 at 09:28:26PM -0700, Andrew Morton wrote: > > On Wed, 11 Mar 2009 01:31:55 +0100 Daniel Mack wrote: > > > > All looks fine to me. > > > > > > > > Acked-by: Jonathan Cameron > > > > I cannot find this review which Jonathan performed. Fumbled > > reply-to-all, or did vger break? > > Jonathan replied to the posting on linux-i2c and linux-kernel wasn't in > the loop, sorry. Find his posting here: > > http://marc.info/?l=linux-i2c&m=123669064909549&w=2 OK. Please always use reply-to-all, guys. > > I can take care of it. > > > > Was any thought given to the CONFIG_SYSFS=n situation? > > You're right, it should depend on that. You want me so send a patch on > top of the other or one that replaces it? Either way is OK by me at this time.