[PATCH] Fix sparse warnings for I2C_BOARD_INFO()

[PATCH] Fix sparse warnings for I2C_BOARD_INFO()

[Ben Hutchings]

Since the first argument to I2C_BOARD_INFO() must be a string constant,
there is no need to parenthesise it, and adding parentheses results in
an invalid initialiser for char[].  gcc obviously accepts this syntax as
an extension, but sparse complains, e.g.:

drivers/net/sfc/boards.c:173:2: warning: array initialized from parenthesized string constant

Therefore, remove the parentheses.

Signed-off-by: Ben Hutchings <bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
---
 i2c.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index c86c3b0..f352a0a 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -274,7 +274,7 @@ struct i2c_board_info {
  * are provided using conventional syntax.
  */
 #define I2C_BOARD_INFO(dev_type, dev_addr) \
-	.type = (dev_type), .addr = (dev_addr)
+	.type = dev_type, .addr = (dev_addr)
 
 
 /* Add-on boards should register/unregister their devices; e.g. a board

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: [PATCH] Fix sparse warnings for I2C_BOARD_INFO()

[Jean Delvare]

Hi Ben,

On Wed, 08 Apr 2009 17:57:33 +0100, Ben Hutchings wrote:
> Since the first argument to I2C_BOARD_INFO() must be a string constant,
> there is no need to parenthesise it, and adding parentheses results in
> an invalid initialiser for char[].  gcc obviously accepts this syntax as
> an extension, but sparse complains, e.g.:
> 
> drivers/net/sfc/boards.c:173:2: warning: array initialized from parenthesized string constant
> 
> Therefore, remove the parentheses.
> 
> Signed-off-by: Ben Hutchings <bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
> ---
>  i2c.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ---
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index c86c3b0..f352a0a 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -274,7 +274,7 @@ struct i2c_board_info {
>   * are provided using conventional syntax.
>   */
>  #define I2C_BOARD_INFO(dev_type, dev_addr) \
> -	.type = (dev_type), .addr = (dev_addr)
> +	.type = dev_type, .addr = (dev_addr)
>  
>  
>  /* Add-on boards should register/unregister their devices; e.g. a board
> 

Good catch! Applied, thanks.

-- 
Jean Delvare