From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Subject: [PATCH] i2c: Let new-style drivers implement attach_adapter
Date: Fri, 10 Apr 2009 15:51:03 +0200 [thread overview]
Message-ID: <20090410155103.3cbdaf1e@hyperion.delvare> (raw)
While it isn't the way the standard device binding model works, it is
OK for new-style drivers to implement attach_adapter. It may help
convert the renaming legacy drivers to new style drivers faster.
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
---
Johannes, you'll need to apply this patch before you can test the
onyx/tas conversion patch I sent to you yesterday.
drivers/i2c/i2c-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.30-rc1.orig/drivers/i2c/i2c-core.c 2009-04-10 15:22:22.000000000 +0200
+++ linux-2.6.30-rc1/drivers/i2c/i2c-core.c 2009-04-10 15:31:19.000000000 +0200
@@ -716,8 +716,7 @@ int i2c_register_driver(struct module *o
/* new style driver methods can't mix with legacy ones */
if (is_newstyle_driver(driver)) {
- if (driver->attach_adapter || driver->detach_adapter
- || driver->detach_client) {
+ if (driver->detach_adapter || driver->detach_client) {
printk(KERN_WARNING
"i2c-core: driver [%s] is confused\n",
driver->driver.name);
--
Jean Delvare
next reply other threads:[~2009-04-10 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 13:51 Jean Delvare [this message]
[not found] ` <20090410155103.3cbdaf1e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-15 6:57 ` [PATCH] i2c: Let new-style drivers implement attach_adapter Paulius Zaleckas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410155103.3cbdaf1e@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox