From: Mark Brown <broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/5] [ARM] pxa: lx: add PCON i2c driver
Date: Mon, 20 Apr 2009 13:25:19 +0100 [thread overview]
Message-ID: <20090420122519.GC8776@sirena.org.uk> (raw)
In-Reply-To: <20090420121805.GE3653-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On Mon, Apr 20, 2009 at 01:18:05PM +0100, Russell King - ARM Linux wrote:
> On Sun, Apr 19, 2009 at 12:11:14PM +0100, Mark Brown wrote:
> > Surely that's just an implementation detail? As I understand your
> > description the microcontroller is hiding the control interfaces of the
> > other things it controls so the function is pretty similar.
> No, it's a question of whether drivers/mfd is right. The "shovel
> everything that doesn't fit elsewhere into drivers/mfd" approach
> is just creating yet another problem, just like drivers/i2c/chips
> is percieved to be. The only difference is that it becomes someone
> elses problem.
Well, my thinking was that it looks like you've got a bunch of
subsystem-specific drivers for this chip with a core driver managing
shared resources like I/O with the device. To my mind that's pretty
much the use case for MFD.
As far as general dumping grounds goes we already have drivers/misc.
prev parent reply other threads:[~2009-04-20 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 14:19 [PATCH 0/5] PXA LX platform support Russell King - ARM Linux
[not found] ` <20090418141932.GA1236-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-18 14:20 ` [PATCH 1/5] [ARM] pxa: lx: add PCON i2c driver Russell King
[not found] ` <1240064452-14691-1-git-send-email-linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
2009-04-18 14:29 ` Jean Delvare
[not found] ` <20090418162900.0dc16531-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-18 14:42 ` Russell King - ARM Linux
[not found] ` <20090418144234.GB1236-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-18 17:34 ` Mark Brown
2009-04-18 18:10 ` Russell King - ARM Linux
[not found] ` <20090418181030.GC1236-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-19 11:11 ` Mark Brown
[not found] ` <20090419111114.GA8569-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-04-20 12:18 ` Russell King - ARM Linux
[not found] ` <20090420121805.GE3653-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-04-20 12:25 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420122519.GC8776@sirena.org.uk \
--to=broonie-gfdadszt00ze9xe1eozjha@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-xIg/pKzrS19vn6HldHNs0ANdhmdF6hFW@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox