Re: [Patch] MPC Adapter: read class attribute from device tree

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]


> For MPC adapter there is no class assigned as it is done in other
> adapters.

Still, the trend is to use the class field less, not more often. Probing
causes more pain than gain. Most of us have been through that, try to
believe us.

> This way no new-style client will ever be instantiated.

Sorry, this seems wrong to me:

1) The client _instance_ does come from the dts, as Jean explained
before. Did you get the difference? You said yourself that you could see
the entries in sysfs. It seems just that it does not get connected to
the driver. This should be the place to fix the error.

2) When I showed you the output of modprobing the rtc-ds1307 driver, I
was using exactly this i2c-master driver (the board uses an MPC5200B).
Plus, I often use at24 as a module. Doesn't look like a problem in the
infrastructure to me.

> this patch class assignment is read from device tree.
> Necessary entry:
> class = <1>; /* I2C_CLASS_HWMON (iic.h) */

The device tree is OS independent. You are encoding something
linux-specific into it. This is regularly rejected. I am quite surprised
to see that there is such a thing in i2c-cpm. Lucky punch, I guess ;)
Should be removed IMHO.

Have you already posted the DTS snipplet for your I2C setup?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]