From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: "Wang, Wen W" <wen.w.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/1] I2C: I2C controller driver for Intel Moorestown platform
Date: Thu, 23 Apr 2009 11:29:35 +0200 [thread overview]
Message-ID: <20090423112935.306ba11a@hyperion.delvare> (raw)
In-Reply-To: <0A882F4D99BBF6449D58E61AAFD7EDD6136779F1-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hi Wen,
On Thu, 23 Apr 2009 17:00:56 +0800, Wang, Wen W wrote:
> Hi Jean,
>
> This is a description for the patch:
> 1. Patch for I2C controller driver for Intel low power platform "Moorestown".
> 2. The driver depends on a GPIO driver for Intel Moorestown platform.
> 3. The patch will:
> a. Add i2c_mrst.c and i2c_mrst.h to kernel directory "drivers/i2c/busses"
Why such a cryptic name? You know, this isn't MS-DOS, names can be
longer than 8 characters ;)
> b. Add items into kernel files "drivers/i2c/busses/Kconfig" and "drivers/i2c/Makefile".
> c. Modify i2c-boardinfo.c to export i2c_register_board_info() function and add code to detect if a device is already in i2c_board_list.
This last item should go to a separate patch, so that it can be
discussed. It is not clear to me why you would need to export functions
nobody else needed to export. It will be easier to review and merge
your code if the bus driver itself is in one patch and any required
integration changes are in another.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2009-04-23 9:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 14:23 Questions for submitting driver to I2C subsystem Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD610424EB0-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-04-16 9:14 ` Jean Delvare
[not found] ` <20090416111436.296cdd12-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-23 9:00 ` [PATCH 0/1] I2C: I2C controller driver for Intel Moorestown platform Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD6136779F1-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-04-23 9:29 ` Jean Delvare [this message]
[not found] ` <20090423112935.306ba11a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-23 9:55 ` Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD613677A5B-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-04-23 11:22 ` Jean Delvare
[not found] ` <20090423132224.25553a5b-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-30 7:15 ` Wang, Wen W
2009-04-23 9:04 ` [PATCH 1/1] " Wang, Wen W
2009-04-23 10:19 ` [PATCH 0/2] " Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD613677A65-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-04-23 10:22 ` [PATCH 1/2] " Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD613677A69-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-04-23 10:25 ` [PATCH 2/2] " Wang, Wen W
2009-05-14 7:35 ` [PATCH 0/1] " Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD62876816C-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-05-14 7:39 ` [PATCH 1/1] " Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD628768177-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-06-15 11:50 ` Jean Delvare
[not found] ` <20090615135058.1bf40a75-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-26 2:41 ` Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD62F26B15F-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-06-26 7:50 ` Jean Delvare
[not found] ` <20090626095026.22c5d6c1-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-26 7:54 ` Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD62F26B3F4-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-12-17 13:28 ` Jean Delvare
[not found] ` <20091217142836.01af265c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-12-18 1:37 ` Wang, Wen W
2009-05-14 7:52 ` [PATCH 0/1] " Jean Delvare
[not found] ` <20090514095201.577b17c4-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-05-14 10:50 ` Wang, Wen W
2009-05-27 2:06 ` Wang, Wen W
[not found] ` <0A882F4D99BBF6449D58E61AAFD7EDD62EEF13AC-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-05-27 6:39 ` Jean Delvare
[not found] ` <20090527083957.20641ebc-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-09 8:45 ` Jean Delvare
[not found] ` <20090609104555.6d81c106-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-09 9:00 ` Wen Wang
[not found] ` <20090609090049.GB28640-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2009-06-09 9:28 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423112935.306ba11a@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wen.w.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).