public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: 2.6.30-rc3 i2c build warnings
Date: Sat, 25 Apr 2009 08:43:44 +0200	[thread overview]
Message-ID: <20090425084344.2c8c62da@hyperion.delvare> (raw)
In-Reply-To: <alpine.LFD.2.00.0904241243270.10096-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

Hi Len,

On Fri, 24 Apr 2009 12:45:53 -0400 (EDT), Len Brown wrote:
> drivers/i2c/i2c-core.c:312: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:313: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:653: warning: ‘detach_client’ is deprecated 
> (declared at include/linux/i2c.h:154)
> drivers/i2c/i2c-core.c:719: warning: ‘detach_client’ is deprecated 
> (declared at include/linux/i2c.h:154)
> drivers/i2c/i2c-core.c:788: warning: ‘detach_client’ is deprecated 
> (declared at include/linux/i2c.h:154)
> drivers/i2c/i2c-core.c:869: warning: ‘client_register’ is deprecated 
> (declared at include/linux/i2c.h:356)
> drivers/i2c/i2c-core.c:870: warning: ‘client_register’ is deprecated 
> (declared at include/linux/i2c.h:356)
> drivers/i2c/i2c-core.c:884: warning: ‘i2c_attach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:835)
> drivers/i2c/i2c-core.c:884: warning: ‘i2c_attach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:835)
> drivers/i2c/i2c-core.c:891: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:892: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:912: warning: ‘i2c_detach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:887)
> drivers/i2c/i2c-core.c:912: warning: ‘i2c_detach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:887)

I am aware of these. The problem is that these functions are exported
and are both used externally (which is deprecated, thus the warnings)
and internally (which is OK, but I don't know how to disable the
deprecation warnings locally.)

When the last few remaining legacy drivers have been converted, we can
stop exporting these functions, and the warnings will go away.
Unfortunately it will not happen in 2.6.30 because the remaining
drivers were converted a little late in the 2.6.30 release cycle [1].
I'm sorry about this, I did my best but I can't forcibly push patches
to maintainers if they don't want them.

[1] http://ozlabs.org/pipermail/linuxppc-dev/2009-April/071008.html

If you know of a simple way to silent the deprecation warnings in
i2c-core meanwhile, I'm all ears. I can think of one method (converting
all these functions to wrappers to internal versions) but this seems a
lot of work for something that will go away in 2.6.31 anyway.

Thanks,
-- 
Jean Delvare

      parent reply	other threads:[~2009-04-25  6:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 16:45 2.6.30-rc3 i2c build warnings Len Brown
     [not found] ` <alpine.LFD.2.00.0904241243270.10096-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-04-25  6:43   ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090425084344.2c8c62da@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox