2.6.30-rc3 i2c build warnings

2.6.30-rc3 i2c build warnings

[Len Brown]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1483 bytes --]

drivers/i2c/i2c-core.c:312: warning: ‘client_unregister’ is deprecated 
(declared at include/linux/i2c.h:357)
drivers/i2c/i2c-core.c:313: warning: ‘client_unregister’ is deprecated 
(declared at include/linux/i2c.h:357)
drivers/i2c/i2c-core.c:653: warning: ‘detach_client’ is deprecated 
(declared at include/linux/i2c.h:154)
drivers/i2c/i2c-core.c:719: warning: ‘detach_client’ is deprecated 
(declared at include/linux/i2c.h:154)
drivers/i2c/i2c-core.c:788: warning: ‘detach_client’ is deprecated 
(declared at include/linux/i2c.h:154)
drivers/i2c/i2c-core.c:869: warning: ‘client_register’ is deprecated 
(declared at include/linux/i2c.h:356)
drivers/i2c/i2c-core.c:870: warning: ‘client_register’ is deprecated 
(declared at include/linux/i2c.h:356)
drivers/i2c/i2c-core.c:884: warning: ‘i2c_attach_client’ is deprecated 
(declared at drivers/i2c/i2c-core.c:835)
drivers/i2c/i2c-core.c:884: warning: ‘i2c_attach_client’ is deprecated 
(declared at drivers/i2c/i2c-core.c:835)
drivers/i2c/i2c-core.c:891: warning: ‘client_unregister’ is deprecated 
(declared at include/linux/i2c.h:357)
drivers/i2c/i2c-core.c:892: warning: ‘client_unregister’ is deprecated 
(declared at include/linux/i2c.h:357)
drivers/i2c/i2c-core.c:912: warning: ‘i2c_detach_client’ is deprecated 
(declared at drivers/i2c/i2c-core.c:887)
drivers/i2c/i2c-core.c:912: warning: ‘i2c_detach_client’ is deprecated 
(declared at drivers/i2c/i2c-core.c:887)


thanks,
Len Brown, Intel Open Source Technology Center

Re: 2.6.30-rc3 i2c build warnings

[Jean Delvare]

Hi Len,

On Fri, 24 Apr 2009 12:45:53 -0400 (EDT), Len Brown wrote:
> drivers/i2c/i2c-core.c:312: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:313: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:653: warning: ‘detach_client’ is deprecated 
> (declared at include/linux/i2c.h:154)
> drivers/i2c/i2c-core.c:719: warning: ‘detach_client’ is deprecated 
> (declared at include/linux/i2c.h:154)
> drivers/i2c/i2c-core.c:788: warning: ‘detach_client’ is deprecated 
> (declared at include/linux/i2c.h:154)
> drivers/i2c/i2c-core.c:869: warning: ‘client_register’ is deprecated 
> (declared at include/linux/i2c.h:356)
> drivers/i2c/i2c-core.c:870: warning: ‘client_register’ is deprecated 
> (declared at include/linux/i2c.h:356)
> drivers/i2c/i2c-core.c:884: warning: ‘i2c_attach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:835)
> drivers/i2c/i2c-core.c:884: warning: ‘i2c_attach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:835)
> drivers/i2c/i2c-core.c:891: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:892: warning: ‘client_unregister’ is deprecated 
> (declared at include/linux/i2c.h:357)
> drivers/i2c/i2c-core.c:912: warning: ‘i2c_detach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:887)
> drivers/i2c/i2c-core.c:912: warning: ‘i2c_detach_client’ is deprecated 
> (declared at drivers/i2c/i2c-core.c:887)

I am aware of these. The problem is that these functions are exported
and are both used externally (which is deprecated, thus the warnings)
and internally (which is OK, but I don't know how to disable the
deprecation warnings locally.)

When the last few remaining legacy drivers have been converted, we can
stop exporting these functions, and the warnings will go away.
Unfortunately it will not happen in 2.6.30 because the remaining
drivers were converted a little late in the 2.6.30 release cycle [1].
I'm sorry about this, I did my best but I can't forcibly push patches
to maintainers if they don't want them.

[1] http://ozlabs.org/pipermail/linuxppc-dev/2009-April/071008.html

If you know of a simple way to silent the deprecation warnings in
i2c-core meanwhile, I'm all ears. I can think of one method (converting
all these functions to wrappers to internal versions) but this seems a
lot of work for something that will go away in 2.6.31 anyway.

Thanks,
-- 
Jean Delvare