public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Krzysztof Helt <krzysztof.h1-5tc4TXWwyLM@public.gmane.org>
Subject: [PATCH] i2c: Do not probe for TV chips on Voodoo3 adapters
Date: Sat, 25 Apr 2009 17:27:08 +0200	[thread overview]
Message-ID: <20090425172708.0622f5b3@hyperion.delvare> (raw)

There's no point in giving the I2C bus of Voodoo3 adapters a class
value, there's no video chip driver checking for it anymore. If
support is ever needed, the video device should be instantiated
explicitly rather than probed.

To the best of my knowledge the only video chip that can be found on
these boards is a BT869 video encoder, for which no support exists
currently.

Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Krzysztof Helt <krzysztof.h1-5tc4TXWwyLM@public.gmane.org>
---
 drivers/i2c/busses/i2c-voodoo3.c |    1 -
 drivers/video/tdfxfb.c           |    1 -
 2 files changed, 2 deletions(-)

--- linux-2.6.30-rc3.orig/drivers/i2c/busses/i2c-voodoo3.c	2009-03-24 13:43:33.000000000 +0100
+++ linux-2.6.30-rc3/drivers/i2c/busses/i2c-voodoo3.c	2009-04-25 12:14:08.000000000 +0200
@@ -163,7 +163,6 @@ static struct i2c_algo_bit_data voo_i2c_
 
 static struct i2c_adapter voodoo3_i2c_adapter = {
 	.owner		= THIS_MODULE,
-	.class		= I2C_CLASS_TV_ANALOG, 
 	.name		= "I2C Voodoo3/Banshee adapter",
 	.algo_data	= &voo_i2c_bit_data,
 };
--- linux-2.6.30-rc3.orig/drivers/video/tdfxfb.c	2009-04-08 08:53:35.000000000 +0200
+++ linux-2.6.30-rc3/drivers/video/tdfxfb.c	2009-04-25 12:13:59.000000000 +0200
@@ -1315,7 +1315,6 @@ static int __devinit tdfxfb_setup_i2c_bu
 
 	strlcpy(chan->adapter.name, name, sizeof(chan->adapter.name));
 	chan->adapter.owner		= THIS_MODULE;
-	chan->adapter.class		= I2C_CLASS_TV_ANALOG;
 	chan->adapter.algo_data		= &chan->algo;
 	chan->adapter.dev.parent	= dev;
 	chan->algo.setsda		= tdfxfb_i2c_setsda;

-- 
Jean Delvare

             reply	other threads:[~2009-04-25 15:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-25 15:27 Jean Delvare [this message]
     [not found] ` <20090425172708.0622f5b3-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-26 15:25   ` [PATCH] i2c: Do not probe for TV chips on Voodoo3 adapters Krzysztof Helt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090425172708.0622f5b3@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=krzysztof.h1-5tc4TXWwyLM@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox