Re: [PATCH 0/6] i2c: Get rid of the legacy binding model

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Sat, 2 May 2009 12:14:02 -0700, David Brownell wrote:
> On Saturday 02 May 2009, Jean Delvare wrote:
> >  Documentation/feature-removal-schedule.txt |   10 -
> >  Documentation/i2c/writing-clients          |   16 -
> >  drivers/i2c/i2c-core.c                     |  366 +++--------------------------
> >  include/linux/i2c.h                        |   57 +----
> 
> Which makes all but patch #4 *very* easy to review.
> All they do is remove code.  Unless that breaks a
> build, those removals have a hard time making any
> trouble.  ;)

Well, removing code can always break things. For example, say I remove
all the locking code in the kernel... ;)

> >  4 files changed, 48 insertions(+), 401 deletions(-)
> > 
> > From a binary perspective, "size" announces an 18% shrink.
> 
> And Linux now builds without all those warnings, yes?

Yes it does :)

> Plus from a code complexity perspective, it's even
> better ... it removes 100% of the high level confusion
> associated with that legacy model, and the bugs and
> fragility caused by that.  (Or maybe I should say
> that it *finishes* removing that.)

Thanks for doing all the hard work :)

> Glad to see this.  I presume this will sit in -next
> for a while and merge in 2.6.31-early?

Exactly. Where "early" is unfortunately bound to the few remaining
legacy drivers, the conversion of which is supposed to be merged by
their respective maintainers. But anyway, the hard deadline is
2.6.31-rc1.

-- 
Jean Delvare