linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] ST DDC I2C U300 bus driver v2
@ 2009-05-06 13:16 Linus Walleij
       [not found] ` <63386a3d0905060616u563aed60i8b134044078f099f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2009-05-06 13:16 UTC (permalink / raw)
  To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
  Cc: STEricsson_nomadik_linux-nkJGhpqTU55BDgjK7y7TUQ,
	andrea.gallo-0IS4wlFg1OjSUeElwK9/Pw, Linus Walleij

Updated patch for this driver, please tell me if it's good enough
enough for mainlining now...

Changelog v1->v2:

* Renamed from i2c-stddci2c to i2c-stu300, also in function
  prefixes and module name (so as not to confuse when tracing
  kernel calls).

* Removed all unnecessary #include <> directives.

* Replaced 8bit accessor macros with inline functions.

* Replaced all pr_debug() with proper dev_dbg() calls.

* Moved clock settings over to a table lookup.

* Introduced more documentation especially of state machine
  events. Described as far as the documentation goes.

* Clarified that zero-length messages are unsupported.

* Introduced more linespacing in terse sections to ease
  readability.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2
       [not found] ` <63386a3d0905060616u563aed60i8b134044078f099f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2009-05-08  8:17   ` Linus Walleij
       [not found]     ` <63386a3d0905080117h16bd9e13p481af6186617fbb2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2009-05-08  8:17 UTC (permalink / raw)
  To: linux-i2c-u79uwXL29TY76Z2rM5mHXA

2009/5/6 Linus Walleij <linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:

> Updated patch for this driver, please tell me if it's good enough
> enough for mainlining now...

No reply means yes I assume :-)

Do I send this directly to Jean for integration?

Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2
       [not found]     ` <63386a3d0905080117h16bd9e13p481af6186617fbb2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2009-05-08 10:15       ` Jean Delvare
       [not found]         ` <20090508121526.0479ff27-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Jean Delvare @ 2009-05-08 10:15 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA

On Fri, 8 May 2009 10:17:58 +0200, Linus Walleij wrote:
> 2009/5/6 Linus Walleij <linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> 
> > Updated patch for this driver, please tell me if it's good enough
> > enough for mainlining now...
> 
> No reply means yes I assume :-)

Wrong assumption. No reply means we are busy. In other words: be
patient.

> Do I send this directly to Jean for integration?

Doesn't the platform this driver is aimed at qualify as embedded? I
doubt this driver is something for me.

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2
       [not found]         ` <20090508121526.0479ff27-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
@ 2009-05-08 12:36           ` Linus Walleij
       [not found]             ` <63386a3d0905080536g252532fena3078cc8f9e891b6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2009-05-08 12:36 UTC (permalink / raw)
  To: linux-i2c-u79uwXL29TY76Z2rM5mHXA

2009/5/8 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>:

>> No reply means yes I assume :-)
>
> Wrong assumption. No reply means we are busy. In other words: be
> patient.

Aw sorry man. I still need to learn patience, I know.

> Doesn't the platform this driver is aimed at qualify as embedded? I
> doubt this driver is something for me.

It does, so Ben is the integrator then I assume.

Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2
       [not found]             ` <63386a3d0905080536g252532fena3078cc8f9e891b6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2009-05-08 12:45               ` Jean Delvare
  2009-05-11 23:14               ` Ben Dooks
  1 sibling, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2009-05-08 12:45 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang

On Fri, 8 May 2009 14:36:30 +0200, Linus Walleij wrote:
> 2009/5/8 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>:
> 
> >> No reply means yes I assume :-)
> >
> > Wrong assumption. No reply means we are busy. In other words: be
> > patient.
> 
> Aw sorry man. I still need to learn patience, I know.
> 
> > Doesn't the platform this driver is aimed at qualify as embedded? I
> > doubt this driver is something for me.
> 
> It does, so Ben is the integrator then I assume.

Correct. Or possibly Wolfram if Ben is too busy.

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2
       [not found]             ` <63386a3d0905080536g252532fena3078cc8f9e891b6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  2009-05-08 12:45               ` Jean Delvare
@ 2009-05-11 23:14               ` Ben Dooks
       [not found]                 ` <20090511231459.GB23114-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
  1 sibling, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2009-05-11 23:14 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA

On Fri, May 08, 2009 at 02:36:30PM +0200, Linus Walleij wrote:
> 2009/5/8 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>:
> 
> >> No reply means yes I assume :-)
> >
> > Wrong assumption. No reply means we are busy. In other words: be
> > patient.
> 
> Aw sorry man. I still need to learn patience, I know.
> 
> > Doesn't the platform this driver is aimed at qualify as embedded? I
> > doubt this driver is something for me.
> 
> It does, so Ben is the integrator then I assume.

Always post the patch you want integrating to the
relevant mailing list. In my case, a direct CC doesn't
hurt.

I'll be reviewing patches for the next kernel closer to
the end of the week as I've still got some other arch
fixing to do.

-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2
       [not found]                 ` <20090511231459.GB23114-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
@ 2009-05-19  9:34                   ` Linus Walleij
  0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2009-05-19  9:34 UTC (permalink / raw)
  To: Ben Dooks; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang

2009/5/12 Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>:

> I'll be reviewing patches for the next kernel closer to
> the end of the week as I've still got some other arch
> fixing to do.

I know you're busy, sorry add to that burden... Can Wolfram
look at this instead perhaps?

Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-05-19  9:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-06 13:16 [PATCH 0/1] ST DDC I2C U300 bus driver v2 Linus Walleij
     [not found] ` <63386a3d0905060616u563aed60i8b134044078f099f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-08  8:17   ` Linus Walleij
     [not found]     ` <63386a3d0905080117h16bd9e13p481af6186617fbb2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-08 10:15       ` Jean Delvare
     [not found]         ` <20090508121526.0479ff27-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-05-08 12:36           ` Linus Walleij
     [not found]             ` <63386a3d0905080536g252532fena3078cc8f9e891b6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-08 12:45               ` Jean Delvare
2009-05-11 23:14               ` Ben Dooks
     [not found]                 ` <20090511231459.GB23114-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-05-19  9:34                   ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).