From: Tony Lindgren <tony@atomide.com>
To: Jagadeesh Bhaskar Pakaravoor <jagadeeshbp@gmail.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
Syed Rafiuddin <rafiuddin.syed@ti.com>,
linux-omap@vger.kernel.org, ben-linux@fluff.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] I2C:Moving Register Defines to Header File
Date: Thu, 14 May 2009 13:40:34 -0700 [thread overview]
Message-ID: <20090514204033.GR5593@atomide.com> (raw)
In-Reply-To: <561678670905140334x3a5588f3i540ee692890e50e@mail.gmail.com>
* Jagadeesh Bhaskar Pakaravoor <jagadeeshbp@gmail.com> [090514 03:34]:
> > IMO, The regs do not need to move to a separate header unless they will
> > be used outside of i2c-omap.c.
> >
> Would it not be cleaner to move them to a separate header file,
> especially considering the fact that we have some 19 registers for
> OMAP3 I2C and when we redefine them for OMAP4, there would be 38
> (infact 40, including the two new registers) lines of just register
> definitions at the top of the file?
I agree with Kevin, unless the defines are used in other files there
should not be need for having a separate header file.
Tony
prev parent reply other threads:[~2009-05-14 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52671.192.168.10.89.1242133785.squirrel@dbdmail.itg.ti.com>
[not found] ` <52671.192.168.10.89.1242133785.squirrel-pJFUjGLopx31T2qfsofKZtBPR1lH4CV8@public.gmane.org>
2009-05-12 13:13 ` [PATCH] I2C:Moving Register Defines to Header File Felipe Balbi
2009-05-12 15:01 ` Kevin Hilman
[not found] ` <87hbzqe55y.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2009-05-13 8:26 ` Syed Rafiuddin
[not found] ` <57428.192.168.10.89.1242203177.squirrel-pJFUjGLopx31T2qfsofKZtBPR1lH4CV8@public.gmane.org>
2009-05-13 13:23 ` Kevin Hilman
[not found] ` <87octx9lxn.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2009-05-14 10:34 ` Jagadeesh Bhaskar Pakaravoor
2009-05-14 20:40 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090514204033.GR5593@atomide.com \
--to=tony@atomide.com \
--cc=ben-linux@fluff.org \
--cc=jagadeeshbp@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rafiuddin.syed@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).