Re: [PATCH] I2C:Moving Register Defines to Header File

Re: [PATCH] I2C:Moving Register Defines to Header File

[Felipe Balbi]

On Tue, May 12, 2009 at 03:09:45PM +0200, ext Syed Rafiuddin wrote:
> This patch creates i2c-omap.h header and moves register and bit definition
> macros to it from i2c-omap.c
> 
> Signed-off-by: Syed Rafiuddin <rafiuddin.syed-l0cyMroinI0@public.gmane.org>
> Acked-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>

Any special need for that ? will those registers be accessed outside
i2c-omap.c ?? If not, I'd rather keep them in the c file.

BTW, this should go straight to Ben Dooks and i2c@vger. Adding them to
cc.

-- 
balbi

Re: [PATCH] I2C:Moving Register Defines to Header File

[Kevin Hilman]

"Syed Rafiuddin" <rafiuddin.syed-l0cyMroinI0@public.gmane.org> writes:

> This patch creates i2c-omap.h header and moves register and bit definition
> macros to it from i2c-omap.c

Please use the description to describe the motivation for the changes
and the problems it is addressing/fixing. 

In other words, you described what your patch does but not why.

Kevin

Re: [PATCH] I2C:Moving Register Defines to Header File

[Syed Rafiuddin]

> "Syed Rafiuddin" <rafiuddin.syed-l0cyMroinI0@public.gmane.org> writes:
>
>> This patch creates i2c-omap.h header and moves register and bit definition
>> macros to it from i2c-omap.c
>
> Please use the description to describe the motivation for the changes
> and the problems it is addressing/fixing.
>
> In other words, you described what your patch does but not why.

The intention of the patch is to have a separate header which will have omap3
and omap4 related register definitions. As omap4 has different offset addresses
with respect to omap3,adding omap4 related stuff in the same file will leave
the file look ugly.

-Syed Rafiuddin

Re: [PATCH] I2C:Moving Register Defines to Header File

[Kevin Hilman]

"Syed Rafiuddin" <rafiuddin.syed-l0cyMroinI0@public.gmane.org> writes:

>> "Syed Rafiuddin" <rafiuddin.syed-l0cyMroinI0@public.gmane.org> writes:
>>
>>> This patch creates i2c-omap.h header and moves register and bit definition
>>> macros to it from i2c-omap.c
>>
>> Please use the description to describe the motivation for the changes
>> and the problems it is addressing/fixing.
>>
>> In other words, you described what your patch does but not why.
>
> The intention of the patch is to have a separate header which will have omap3
> and omap4 related register definitions. As omap4 has different offset addresses
> with respect to omap3,adding omap4 related stuff in the same file will leave
> the file look ugly.

IMO, The regs do not need to move to a separate header unless they will
be used outside of i2c-omap.c.

Kevin

Re: [PATCH] I2C:Moving Register Defines to Header File

[Jagadeesh Bhaskar Pakaravoor]

> IMO, The regs do not need to move to a separate header unless they will
> be used outside of i2c-omap.c.
>
Would it not be cleaner to move them to a separate header file,
especially considering the fact that we have some 19 registers for
OMAP3 I2C and when we redefine them for OMAP4, there would be 38
(infact 40, including the two new registers) lines of just register
definitions at the top of the file?

--
Jagadeesh

Re: [PATCH] I2C:Moving Register Defines to Header File

[Tony Lindgren]

* Jagadeesh Bhaskar Pakaravoor <jagadeeshbp@gmail.com> [090514 03:34]:
> > IMO, The regs do not need to move to a separate header unless they will
> > be used outside of i2c-omap.c.
> >
> Would it not be cleaner to move them to a separate header file,
> especially considering the fact that we have some 19 registers for
> OMAP3 I2C and when we redefine them for OMAP4, there would be 38
> (infact 40, including the two new registers) lines of just register
> definitions at the top of the file?

I agree with Kevin, unless the defines are used in other files there
should not be need for having a separate header file.

Tony