linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Harald Welte <HaraldWelte-yS34VQbMlVtBDgjK7y7TUQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] [I2C] i2c-viapro: Add new PCI device ID For VX855
Date: Sun, 17 May 2009 10:19:52 +0200	[thread overview]
Message-ID: <20090517101952.533373c1@hyperion.delvare> (raw)
In-Reply-To: <20090517060439.GE4909-jI4mzJ+yNOMOwssVsN95jSCwEArCW2h5@public.gmane.org>

Hi Harald,

On Sun, 17 May 2009 14:04:39 +0800, Harald Welte wrote:
> The south bridge of the VIA VX855 chipset has a different PCI Device ID
> so i2c-viapro.c needs to be updated with this.
> 
> Signed-off-by: Harald Welte <HaraldWelte-yS34VQbMlVtBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-viapro.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
> index 02e6f72..7a0b15a 100644
> --- a/drivers/i2c/busses/i2c-viapro.c
> +++ b/drivers/i2c/busses/i2c-viapro.c
> @@ -37,6 +37,7 @@
>     VT8251             0x3287             yes
>     CX700              0x8324             yes
>     VX800/VX820        0x8353             yes
> +   VX855/VX875        0x8409             yes
>  
>     Note: we assume there can only be one device, with one SMBus interface.
>  */
> @@ -469,6 +470,8 @@ static struct pci_device_id vt596_ids[] = {
>  	  .driver_data = SMBBA3 },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800),
>  	  .driver_data = SMBBA3 },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855),
> +	  .driver_data = SMBBA3 },
>  	{ 0, }
>  };
>  

Thanks for your contribution. You did not include
PCI_DEVICE_ID_VIA_VX855 to the list of devices which support I2C block
transactions (in function vt596_probe), is this on purpose or an
overlook?

-- 
Jean Delvare

  parent reply	other threads:[~2009-05-17  8:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-17  6:04 [PATCH] [I2C] i2c-viapro: Add new PCI device ID For VX855 Harald Welte
     [not found] ` <20090517060439.GE4909-jI4mzJ+yNOMOwssVsN95jSCwEArCW2h5@public.gmane.org>
2009-05-17  8:19   ` Jean Delvare [this message]
     [not found]     ` <20090517101952.533373c1-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-05-17 12:59       ` Harald Welte
     [not found]         ` <20090517125940.GA19746-jI4mzJ+yNOMOwssVsN95jSCwEArCW2h5@public.gmane.org>
2009-05-17 14:03           ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090517101952.533373c1@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=HaraldWelte-yS34VQbMlVtBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).